Mesa (main): agx: Don't kill helper threads in ld_var

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: 786871c87e85082dc329fd477447505c0b4871b5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=786871c87e85082dc329fd477447505c0b4871b5

Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sun Feb  6 09:43:48 2022 -0500

agx: Don't kill helper threads in ld_var

Apparently this is yet another .kill bit. Fixes:

dEQP-GLES3.functional.shaders.derivate.dfdx.linear.*
dEQP-GLES3.functional.shaders.derivate.dfdy.linear.*

Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14899>

---

 src/asahi/compiler/agx_pack.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/asahi/compiler/agx_pack.c b/src/asahi/compiler/agx_pack.c
index 93c07ebf3a5..826fb81adb0 100644
--- a/src/asahi/compiler/agx_pack.c
+++ b/src/asahi/compiler/agx_pack.c
@@ -457,6 +457,7 @@ agx_pack_instr(struct util_dynarray *emission, struct util_dynarray *fixups, agx
       assert(index_src.type == AGX_INDEX_IMMEDIATE);
       assert(!(flat && I->perspective));
       unsigned index = index_src.value;
+      bool kill = false; // TODO: optimize
 
       uint64_t raw =
             0x21 | (flat ? (1 << 7) : 0) |
@@ -466,7 +467,7 @@ agx_pack_instr(struct util_dynarray *emission, struct util_dynarray *fixups, agx
             (((uint64_t) index) << 16) |
             (((uint64_t) channels) << 30) |
             (!flat ? (1ull << 46) : 0) | /* XXX */
-            (!flat ? (1ull << 52) : 0) | /* XXX */
+            (kill ? (1ull << 52) : 0) | /* XXX */
             (((uint64_t) (D >> 8)) << 56);
 
       unsigned size = 8;