Mesa (staging/22.0): anv: fix conditional render for vkCmdDrawIndirectByteCountEXT
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Feb 8 17:25:13 UTC 2022
Module: Mesa
Branch: staging/22.0
Commit: 2e1387c7528a3b5e7d53a6613b710c2aaf1e1c17
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2e1387c7528a3b5e7d53a6613b710c2aaf1e1c17
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Sat Feb 5 01:49:18 2022 +0200
anv: fix conditional render for vkCmdDrawIndirectByteCountEXT
We just forgot about conditional render for this entry point.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 2be89cbd826f9a ("anv: Implement vkCmdDrawIndirectByteCountEXT")
Tested-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14891>
(cherry picked from commit 93a90fc85d037e2c6834fb969562391310ae9cd0)
---
.pick_status.json | 2 +-
src/intel/vulkan/genX_cmd_buffer.c | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/.pick_status.json b/.pick_status.json
index d01c432ab78..e1215e074f6 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -85,7 +85,7 @@
"description": "anv: fix conditional render for vkCmdDrawIndirectByteCountEXT",
"nominated": true,
"nomination_type": 1,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": "2be89cbd826f9ac2703127025714a55595de33d3"
},
diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c
index 4ceaa2efc76..7d7d14de044 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel/vulkan/genX_cmd_buffer.c
@@ -4371,6 +4371,9 @@ void genX(CmdDrawIndirectByteCountEXT)(
genX(cmd_buffer_flush_state)(cmd_buffer);
+ if (cmd_buffer->state.conditional_render_enabled)
+ genX(cmd_emit_conditional_render_predicate)(cmd_buffer);
+
if (vs_prog_data->uses_firstvertex ||
vs_prog_data->uses_baseinstance)
emit_base_vertex_instance(cmd_buffer, firstVertex, firstInstance);
@@ -4405,6 +4408,7 @@ void genX(CmdDrawIndirectByteCountEXT)(
anv_batch_emit(&cmd_buffer->batch, GENX(3DPRIMITIVE), prim) {
prim.IndirectParameterEnable = true;
+ prim.PredicateEnable = cmd_buffer->state.conditional_render_enabled;
prim.VertexAccessType = SEQUENTIAL;
prim.PrimitiveTopologyType = cmd_buffer->state.gfx.primitive_topology;
}
More information about the mesa-commit
mailing list