Mesa (main): r300: fix transformation of abs modifiers with negate

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Feb 8 23:06:07 UTC 2022


Module: Mesa
Branch: main
Commit: 1f5330de3a6c54faf7a0ed7485c72a2ce40ac744
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1f5330de3a6c54faf7a0ed7485c72a2ce40ac744

Author: Pavel Ondračka <pavel.ondracka at gmail.com>
Date:   Mon Feb  7 16:49:38 2022 +0100

r300: fix transformation of abs modifiers with negate

It is being overwritten by the memset. Just set the only remaining
member RelAddr explicitly.

Signed-off-by: Pavel Ondračka <pavel.ondracka at gmail.com>
Reviewed-by: Filip Gawin <filip.gawin at zoho.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14915>

---

 src/gallium/drivers/r300/compiler/r3xx_vertprog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/r300/compiler/r3xx_vertprog.c b/src/gallium/drivers/r300/compiler/r3xx_vertprog.c
index 559a8ff54e7..3626d2913c4 100644
--- a/src/gallium/drivers/r300/compiler/r3xx_vertprog.c
+++ b/src/gallium/drivers/r300/compiler/r3xx_vertprog.c
@@ -688,10 +688,10 @@ static int transform_nonnative_modifiers(
 			new_inst->U.I.SrcReg[1] = inst->U.I.SrcReg[i];
 			new_inst->U.I.SrcReg[1].Negate ^= RC_MASK_XYZW;
 
-			memset(&inst->U.I.SrcReg[i], 0, sizeof(inst->U.I.SrcReg[i]));
 			inst->U.I.SrcReg[i].File = RC_FILE_TEMPORARY;
 			inst->U.I.SrcReg[i].Index = temp;
 			inst->U.I.SrcReg[i].Swizzle = RC_SWIZZLE_XYZW;
+			inst->U.I.SrcReg[i].RelAddr = 0;
 		}
 	}
 	return 1;



More information about the mesa-commit mailing list