Mesa (main): intel/fs: Assert that old pull-const code is not used if devinfo->has_lsc

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Feb 9 11:13:23 UTC 2022


Module: Mesa
Branch: main
Commit: e2cd0c3a3c21d99ad0b99d1e21a8cad148a78aaf
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e2cd0c3a3c21d99ad0b99d1e21a8cad148a78aaf

Author: Jordan Justen <jordan.l.justen at intel.com>
Date:   Sun Feb  6 14:13:24 2022 -0800

intel/fs: Assert that old pull-const code is not used if devinfo->has_lsc

Jason changed this to use LSC in:

f5876dfdb9b ("intel/fs: Lower uniform pull constant load message to LSC dataport")

Cc: 22.0 <mesa-stable>
Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14384>

---

 src/intel/compiler/brw_fs_generator.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/intel/compiler/brw_fs_generator.cpp b/src/intel/compiler/brw_fs_generator.cpp
index 55f302a57ce..0af40c739e5 100644
--- a/src/intel/compiler/brw_fs_generator.cpp
+++ b/src/intel/compiler/brw_fs_generator.cpp
@@ -1592,6 +1592,7 @@ fs_generator::generate_uniform_pull_constant_load_gfx7(fs_inst *inst,
    assert(index.type == BRW_REGISTER_TYPE_UD);
    assert(payload.file == BRW_GENERAL_REGISTER_FILE);
    assert(type_sz(dst.type) == 4);
+   assert(!devinfo->has_lsc);
 
    if (index.file == BRW_IMMEDIATE_VALUE) {
       const uint32_t surf_index = index.ud;



More information about the mesa-commit mailing list