Mesa (22.0): 27 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Feb 9 17:44:08 UTC 2022
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=716fc5280adcb1912c817298353c0edc731e76a8
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Feb 9 09:43:34 2022 -0800
VERSION: bump version for 22.0.0-rc2
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2e1387c7528a3b5e7d53a6613b710c2aaf1e1c17
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Sat Feb 5 01:49:18 2022 +0200
anv: fix conditional render for vkCmdDrawIndirectByteCountEXT
We just forgot about conditional render for this entry point.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 2be89cbd826f9a ("anv: Implement vkCmdDrawIndirectByteCountEXT")
Tested-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14891>
(cherry picked from commit 93a90fc85d037e2c6834fb969562391310ae9cd0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a910e58ad8b674cda1ff26264a44cb88c1e9efa6
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Tue Jan 18 10:05:22 2022 +0200
intel/nir: fix shader call lowering
We're replacing a generic instruction by an intel specific one, we
need to remove the previous instruction.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: c5a42e401036 ("intel/fs: fix shader call lowering pass")
Reviewed-by: Caio Oliveira <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13719>
(cherry picked from commit 39f6cd5d799ad077ad41d920dc31c5da1fae3c24)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=54f49993d18b5ba4a4d7d2395a5c1ab7812c86d3
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Thu Feb 3 11:33:26 2022 +0200
intel/fs: don't set allow_sample_mask for CS intrinsics
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 77486db867bd ("intel/fs: Disable sample mask predication for scratch stores")
Reviewed-by: Caio Oliveira <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13719>
(cherry picked from commit c89024e4463389663cf7f7d2f2752de2029efb23)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2b282fb3b5dd6ed94a0b82436cfd0dccde4c4e07
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Feb 8 09:23:49 2022 -0800
.pick_status.json: Update to 5e9df85b1a4504c5b4162e77e139056dc80accc6
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4e67d2aad4df7f7a7e05d1f8da2691ec9f021ccc
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Feb 7 16:19:15 2022 +1000
crocus: find correct relocation target for the bo.
If we have batch a + b, and writing to batch b, causes batch a
to flush, all the bo->index get reset, and we try to submit a -1
to the kernel.
Look the bo index up when creating relocations.
Fixes crash seen in KHR-GL46.compute_shader.pipeline-post-fs
and a trace from Wasteland 3
Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7")
Reviewed-by: Zoltán Böszörményi <zboszor at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14905>
(cherry picked from commit 37c3be6947b43d31e454d1f4adcee8eea49a8f0a)
Conflicts:
src/gallium/drivers/crocus/ci/crocus-hsw-flakes.txt
I've deleted this file, which the original removed an entry from as it
doesn't exist, and the CI isn't run on the 22.0 branch.
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8f5fb1eb10d0d671257c1025a192e4fd29ee5d11
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Thu Feb 3 09:51:52 2022 -0500
zink: min/max blit region in coverage functions
these regions might not have the coords in the correct order, which will
cause them to fail intersection tests, resulting in clears that are never
applied
cc: mesa-stable
fixes:
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_all_buffer_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_color_and_depth_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_color_and_stencil_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_linear_filter_color_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_magnifying_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_minifying_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_missing_buffers_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_nearest_filter_color_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_negative_dimensions_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_negative_height_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_negative_width_blit
GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_scissor_blit
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14867>
(cherry picked from commit 388f23eabe54cb92d71eb5a31b39338585cd4d76)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4587268d2b7b2ed00787c547b2249b59fd96ab90
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Tue Feb 1 10:41:35 2022 -0500
zink: reject invalid draws
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14859>
(cherry picked from commit b656ab75a684807d2718d726dd807726a36f1a0f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a04818a500e162d32aac2b62313e671e8d3c3df4
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Mon Jan 31 10:43:54 2022 -0500
zink: fix PIPE_CAP_TGSI_BALLOT export conditional
this requires VK_EXT_shader_subgroup_ballot
cc: mesa-stable
fixes (lavapipe):
KHR-GL46.shader_ballot_tests.ShaderBallotAvailability
KHR-GL46.shader_ballot_tests.ShaderBallotFunctionRead
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14858>
(cherry picked from commit e38c13830fcbe8f3784dc3adbd736ea72b67fdea)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=59b2c1dddeed061843e783f0514b6913cddd937d
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Fri Feb 4 19:02:54 2022 +0000
radv: fix R_02881C_PA_CL_VS_OUT_CNTL with mixed cull/clip distances
Matches radeonsi.
Seems Vulkan CTS doesn't really test cull distances. Removing
VARYING_SLOT_CULL_DIST0/VARYING_SLOT_CULL_DIST1 variables doesn't break
any of dEQP-VK.clipping.*, except for tests which read the variables in
the fragment shader.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5984
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14882>
(cherry picked from commit 7ddad1b93a131df4c3ec86caf7cacd593caef64f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2ce020120ab2efbdbb5c79170020f59c784e8984
Author: Daniel Stone <daniels at collabora.com>
Date: Fri Feb 4 10:42:19 2022 +0000
egl/wayland: Reset buffer age when destroying buffers
A buffer age of 0 means that the buffer is uninitialised or has unknown
content. We rely on the buffer age initially being 0 through zalloc when
the surface is first created; when they are first used for a swap, we
set their age to 1, and then we increment the age of every buffer in the
chain with a non-zero age when we swap.
Now that we can release buffers, both through dmabuf-feedback as well as
detecting when we're using a deeper swapchain than the compositor needs,
make sure to reset their age as they are released. Without doing this,
the age will stay as it was before it was released and be incremented,
returning the wrong age to the user the first time a previously-released
buffer slot has been reused.
Signed-off-by: Daniel Stone <daniels at collabora.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5977
Fixes: 22d796feb828 ("egl/wayland: break double/tripple buffering feedback loops")
Fixes: b5848b2dac14 ("egl/wayland: use surface dma-buf feedback to allocate surface buffers")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14873>
(cherry picked from commit 3da8300562efeeeeea6c80bce98c830b0da28622)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ba2d22e95f3313450fc4ce80fb900f8e0dd462f3
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Jan 19 16:19:11 2022 +0100
Revert "radv: re-apply "Do not access set layout during vkCmdBindDescriptorSets.""
The most famous RADV revert over the past months. This was an issue
in RADV and not an use-after-free (descriptor set layouts can be
destroyed almost at any time).
This reverts commit b775aaff1ec86f4ebd50867a045695da1fbeb2e1.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14621>
(cherry picked from commit 9ea4029f9fea4ed6131c72a65981b39eb0e2353d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5ff5f3cbf79ac40d49605a93304e8ed01d5001e4
Author: Charmaine Lee <charmainel at vmware.com>
Date: Wed Feb 2 15:12:12 2022 -0800
mesa: fix misaligned pointer returned by dlist_alloc
In cases where the to-be-allocated node size with padding exceeds BLOCK_SIZE
but without padding doesn't, a new block is not created and no padding is done
to the previous instruction, causing a misaligned pointer to be returned.
v2: Per Ilia Mirkin's suggestion, remove the extra condition in the first
if statement, let it unconditionally pad the last instruction if needed.
The updated currentPos will then be taken into account in the
block size checking.
This fixes crash seen with lightsmark and Optuma apitraces
Fixes: 05605d7f537c4 (' mesa: remove display list OPCODE_NOP')
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Neha Bhende <bhenden at vmware.com>
Tested-by: Neha Bhende <bhenden at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14871>
(cherry picked from commit 945a1e0b8cd57403c6a0cbf9b2fec112f233075e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a7a564d7c4bbc33f863f3653c8eb8b35b25f486
Author: Neha Bhende <bhenden at vmware.com>
Date: Thu Feb 3 14:48:09 2022 -0800
svga: store shared_mem_size in svga_compute_shader instead of svga_context
When new context was created, shared_mem_size was getting overwritten.
This fixes glretrace failure seen with manhattan, aztec and BASS2_intro
apitraces
Fixes: 247c61f2d0454a ('svga: Add support for compute shader, shader buffers and image views')
Tested with glretrace, piglit
Reviewed-by: Charmaine Lee <charmainel at vmware.com>
(cherry picked from commit dd6793ec9218782b1b716a87582d7219bae4e75f)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14870>
(cherry picked from commit 9230b28533682fe3126ec5328aba31f16f63864b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2c7d0e1b492f7c5aadd62a36266701c220e72ecc
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Fri Feb 4 08:29:28 2022 -0500
zink: use scanout obj when returning resource param info
embarrassing typo since the base obj has no modifier data available
cc: mesa-stable
fixes #5980
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14875>
(cherry picked from commit 960e72417f3e8885699cf384f690853e14ba44da)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=83eef372a22acce244f0f652e17cacec086a5489
Author: Danylo Piliaiev <dpiliaiev at igalia.com>
Date: Thu Feb 3 18:07:21 2022 +0200
turnip: Unconditionaly remove descriptor set from pool's list on free
We didn't remove desc set from the pool's list if pool was
host_memory_base. On the other hand in there is no point in removing
desc set from the list in DestroyDescriptorPool/ResetDescriptorPool.
Fixes: da7a4751
("turnip: Drop references to layout of all sets on pool reset/destruction")
Fixes cts tests:
dEQP-VK.api.buffer_marker.graphics.default_mem.bottom_of_pipe.memory_dep.draw
dEQP-VK.api.buffer_marker.graphics.default_mem.bottom_of_pipe.memory_dep.dispatch
Signed-off-by: Danylo Piliaiev <dpiliaiev at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14855>
(cherry picked from commit 183bc15bdbe22e46596ffa281781f0c473ad7cb4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0a1f166f4dcf6d33cf6e222b196460c5f853c1ab
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Fri Jan 28 03:23:34 2022 -0800
iris: Make an iris_foreach_batch macro that skips unsupported batches
IRIS_BATCH_BLITTER isn't supported prior to Tigerlake; in general,
batches may not be supported on all hardware. In most cases, querying
them is harmless (if useless): they reference nothing, have no commands
to flush, and so on. However, the fence code does need to know that
certain batches don't exist, so it can avoid adding inter-batch fences
involving them.
This patch introduces a new iris_foreach_batch() iterator macro that
walks over all batches that are actually supported on the platform,
while skipping the others. It provides a central place to update should
we add or reorder more batches in the future.
Fixes various tests in the piglit.spec.ext_external_objects.* category.
Thanks to Tapani Pälli for catching this.
Fixes: a90a1f15 ("iris: Create an IRIS_BATCH_BLITTER for using the BLT command streamer")
Reviewed-by: Caio Oliveira <caio.oliveira at intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14834>
(cherry picked from commit fd0e4aedeb276b64bb58bc0ecfa68db228c3857d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=68242654f80b9f24156175128e1afa9352878a59
Author: Jesse Natalie <jenatali at microsoft.com>
Date: Wed Feb 2 12:39:14 2022 -0800
microsoft/compiler: Only treat tess level location as special if it's a patch constant
Fixes: a550c059 ("microsoft/compiler: For load_input from DS, use loadPatchConstant")
Reviewed-by: Bill Kristiansen <billkris at microsoft.com>
Reviewed-By: Sil Vilerino <sivileri at microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14837>
(cherry picked from commit ce6dbbabf9371a66ce52eba81e6ab394a2a6f7d1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c7bd1f0720dbeb32d70aa722c6f5457f5e4a31ab
Author: Jesse Natalie <jenatali at microsoft.com>
Date: Wed Feb 2 06:57:02 2022 -0800
microsoft/compiler: Only prep phis for the current function
Fixes: 41af9620 ("microsoft/compiler: Emit all NIR functions into the DXIL module")
Reviewed-by: Bill Kristiansen <billkris at microsoft.com>
Reviewed-By: Sil Vilerino <sivileri at microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14837>
(cherry picked from commit 0c711dc823b7db47b615ec7453c9bcba6297e07e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=88762cf59baede448244819ff521b153e205dc4a
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Thu Jan 27 10:43:33 2022 -0500
zink: add VK_BUFFER_USAGE_CONDITIONAL_RENDERING_BIT_EXT for query binds
required by spec
cc: mesa-stable
Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14853>
(cherry picked from commit 1e96542390adaaec2b3e84ef69239f580403b26d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6420dc86cf1ff3abd14095dab077533cfd3da8f0
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Mon Feb 7 21:35:59 2022 -0800
.pick_status.json: Update to 8335fdfeafbe1fd14cb65f9088bbba15d9eb00dc
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a58a01050c769e846cf1d297cdd1a576e82da062
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Feb 2 16:42:24 2022 +0000
aco: don't encode src2 for v_writelane_b32_e64
Encoding src2 doesn't cause issues for print_asm() because we have a
workaround there, but it does for RGP and it seems the developers are not
interested in fixing it.
https://github.com/GPUOpen-Tools/radeon_gpu_profiler/issues/61
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Tested-by: Tatsuyuki Ishi <ishitatsuyuki at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14832>
(cherry picked from commit 0447a2303fb06d6ad1f64e5f079a74bf2cf540da)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b6e296f82333f8a1290f3aefbf554d793bd8003a
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Thu Feb 3 09:35:07 2022 +0100
radeonsi: limit loop unrolling for LLVM < 13
Without this change LLVM 12 hits this error:
"""
LLVM ERROR: Error while trying to spill SGPR0_SGPR1 from class SReg_64:
Cannot scavenge register without an emergency spill slot!
"""
when running glcts KHR-GL46.arrays_of_arrays_gl.AtomicUsage test.
Fixes: 9ff086052ab ("radeonsi: unroll loops of up to 128 iterations")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14848>
(cherry picked from commit eaa87b1a4659c1c06b0ac9e5659943c888dff6d3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fabb6b5c5e7785214fefdfa89354146f3c50eaf0
Author: Iago Toral Quiroga <itoral at igalia.com>
Date: Wed Feb 2 11:39:53 2022 +0100
broadcom/compiler: fix offset alignment for ldunifa when skipping
The intention was to align the address to 4 bytes (32-bit), not
16 bytes.
Fixes: bdb6201ea1 ("broadcom/compiler: use ldunifa with unaligned constant offset")
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14830>
(cherry picked from commit 0a8449b07c48477d97b6252e67562abdd466cf37)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0ec3de0563cdbf82f51cc8c28e59cd96c96e0543
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Wed Feb 2 15:54:45 2022 -0500
llvmpipe: disable PIPE_SHADER_CAP_FP16_CONST_BUFFERS
this cap is broken
cc: mesa-stable
fixes:
GTF-GL46.gtf21.GL2Tests.glGetUniform.glGetUnifor
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14835>
(cherry picked from commit 9a75392cd829df3f8f5a89dfecd4f2103658bfbd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b2be43a1928b21b5a076e86a8e440a6e9194c629
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Wed Feb 2 14:53:45 2022 -0500
zink: disable PIPE_SHADER_CAP_FP16_CONST_BUFFERS
this cap is broken
cc: mesa-stable
fixes:
GTF-GL46.gtf21.GL2Tests.glGetUniform.glGetUniform
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14835>
(cherry picked from commit 9a38dab2d18d5c6c685bdedb921d485bbb305eed)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9e17fcbed20050a2fdb2352f01808da02245cef2
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Thu Feb 3 10:31:57 2022 -0800
.pick_status.json: Update to 0447a2303fb06d6ad1f64e5f079a74bf2cf540da
More information about the mesa-commit
mailing list