Mesa (main): glsl: Don't visit rvalues in the condition of an assignment

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Feb 11 17:59:13 UTC 2022


Module: Mesa
Branch: main
Commit: 5208c116f2715855fc1d234c263ea0d06c4024e9
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5208c116f2715855fc1d234c263ea0d06c4024e9

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Fri Jan 14 18:55:28 2022 -0800

glsl: Don't visit rvalues in the condition of an assignment

At this point, this should always be NULL.

Reviewed-by: Matt Turner <mattst88 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14573>

---

 src/compiler/glsl/ir_rvalue_visitor.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/compiler/glsl/ir_rvalue_visitor.cpp b/src/compiler/glsl/ir_rvalue_visitor.cpp
index d7a4f6689a9..33390b4bc5b 100644
--- a/src/compiler/glsl/ir_rvalue_visitor.cpp
+++ b/src/compiler/glsl/ir_rvalue_visitor.cpp
@@ -118,8 +118,6 @@ ir_visitor_status
 ir_rvalue_base_visitor::rvalue_visit(ir_assignment *ir)
 {
    handle_rvalue(&ir->rhs);
-   handle_rvalue(&ir->condition);
-
    return visit_continue;
 }
 



More information about the mesa-commit mailing list