Mesa (main): util/util_vertex_state_cache: remove error check when deinit
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Feb 22 07:35:14 UTC 2022
Module: Mesa
Branch: main
Commit: 100c80392a9c6631d09accb50e914c6bd995b2a8
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=100c80392a9c6631d09accb50e914c6bd995b2a8
Author: Qiang Yu <yuq825 at gmail.com>
Date: Tue Feb 8 17:49:28 2022 +0800
util/util_vertex_state_cache: remove error check when deinit
Application may exit without freeing created display list, this
may leave the cache not empty.
This is triggered by Abaqus which just close X11 display without
calling any of GLX cleanup functions like glXDestroyContext. But
GLX hook to X11 display close function to free GLX screen resource.
So display list as a context resource has not been freed, but
cache as a screen resource is freed.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Signed-off-by: Qiang Yu <yuq825 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14926>
---
src/gallium/auxiliary/util/u_vertex_state_cache.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_vertex_state_cache.c b/src/gallium/auxiliary/util/u_vertex_state_cache.c
index f98a1071af4..112cd79b4ae 100644
--- a/src/gallium/auxiliary/util/u_vertex_state_cache.c
+++ b/src/gallium/auxiliary/util/u_vertex_state_cache.c
@@ -57,11 +57,6 @@ void
util_vertex_state_cache_deinit(struct util_vertex_state_cache *cache)
{
if (cache->set) {
- set_foreach(cache->set, entry) {
- fprintf(stderr, "mesa: vertex state cache should be empty\n");
- assert(!"vertex state cache should be empty");
- }
-
_mesa_set_destroy(cache->set, NULL);
simple_mtx_destroy(&cache->lock);
}
More information about the mesa-commit
mailing list