Mesa (main): iris,crocus,i915g: Don't stub flush_frontbuffer

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: d986731da97ed1013c071d2acdffde4301c56560
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d986731da97ed1013c071d2acdffde4301c56560

Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Tue Feb 22 09:49:32 2022 -0500

iris,crocus,i915g: Don't stub flush_frontbuffer

This callback is only intended for software rasterizers, layered drivers, and
other special drivers that go through the software winsys path. Remove the
unimplemented stubs from the Intel drivers.

Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Acked-by: Dave Airlie <airlied at redhat.com> [crocus]
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15118>

---

 src/gallium/drivers/crocus/crocus_screen.c | 10 ----------
 src/gallium/drivers/i915/i915_screen.c     | 17 -----------------
 src/gallium/drivers/iris/iris_screen.c     | 10 ----------
 3 files changed, 37 deletions(-)

diff --git a/src/gallium/drivers/crocus/crocus_screen.c b/src/gallium/drivers/crocus/crocus_screen.c
index 43f619b1509..93ccd665acc 100644
--- a/src/gallium/drivers/crocus/crocus_screen.c
+++ b/src/gallium/drivers/crocus/crocus_screen.c
@@ -84,15 +84,6 @@
       unreachable("Unknown hardware generation");       \
    }
 
-static void
-crocus_flush_frontbuffer(struct pipe_screen *_screen,
-                         struct pipe_context *_pipe,
-                         struct pipe_resource *resource,
-                         unsigned level, unsigned layer,
-                         void *context_private, struct pipe_box *box)
-{
-}
-
 static const char *
 crocus_get_vendor(struct pipe_screen *pscreen)
 {
@@ -814,7 +805,6 @@ crocus_screen_create(int fd, const struct pipe_screen_config *config)
    pscreen->get_disk_shader_cache = crocus_get_disk_shader_cache;
    pscreen->is_format_supported = crocus_is_format_supported;
    pscreen->context_create = crocus_create_context;
-   pscreen->flush_frontbuffer = crocus_flush_frontbuffer;
    pscreen->get_timestamp = crocus_get_timestamp;
    pscreen->query_memory_info = crocus_query_memory_info;
    pscreen->get_driver_query_group_info = crocus_get_monitor_group_info;
diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c
index 994496be4ca..5ef24df77d7 100644
--- a/src/gallium/drivers/i915/i915_screen.c
+++ b/src/gallium/drivers/i915/i915_screen.c
@@ -629,22 +629,6 @@ i915_fence_finish(struct pipe_screen *screen, struct pipe_context *ctx,
  * Generic functions
  */
 
-static void
-i915_flush_frontbuffer(struct pipe_screen *screen, struct pipe_context *pipe,
-                       struct pipe_resource *resource, unsigned level,
-                       unsigned layer, void *winsys_drawable_handle,
-                       struct pipe_box *sub_box)
-{
-   /* XXX: Dummy right now. */
-   (void)screen;
-   (void)pipe;
-   (void)resource;
-   (void)level;
-   (void)layer;
-   (void)winsys_drawable_handle;
-   (void)sub_box;
-}
-
 static void
 i915_destroy_screen(struct pipe_screen *screen)
 {
@@ -694,7 +678,6 @@ i915_screen_create(struct i915_winsys *iws)
    is->iws = iws;
 
    is->base.destroy = i915_destroy_screen;
-   is->base.flush_frontbuffer = i915_flush_frontbuffer;
 
    is->base.get_name = i915_get_name;
    is->base.get_vendor = i915_get_vendor;
diff --git a/src/gallium/drivers/iris/iris_screen.c b/src/gallium/drivers/iris/iris_screen.c
index 3070cbea298..d2834a5289a 100644
--- a/src/gallium/drivers/iris/iris_screen.c
+++ b/src/gallium/drivers/iris/iris_screen.c
@@ -80,15 +80,6 @@
       unreachable("Unknown hardware generation"); \
    }
 
-static void
-iris_flush_frontbuffer(struct pipe_screen *_screen,
-                       struct pipe_context *_pipe,
-                       struct pipe_resource *resource,
-                       unsigned level, unsigned layer,
-                       void *context_private, struct pipe_box *box)
-{
-}
-
 static const char *
 iris_get_vendor(struct pipe_screen *pscreen)
 {
@@ -873,7 +864,6 @@ iris_screen_create(int fd, const struct pipe_screen_config *config)
    pscreen->get_disk_shader_cache = iris_get_disk_shader_cache;
    pscreen->is_format_supported = iris_is_format_supported;
    pscreen->context_create = iris_create_context;
-   pscreen->flush_frontbuffer = iris_flush_frontbuffer;
    pscreen->get_timestamp = iris_get_timestamp;
    pscreen->query_memory_info = iris_query_memory_info;
    pscreen->get_driver_query_group_info = iris_get_monitor_group_info;