Mesa (main): anv: Don't fill lowered_storage_image_param on SKL+

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jan 14 22:08:46 UTC 2022


Module: Mesa
Branch: main
Commit: fe0a6b960611771b6765002a315c248da3c07e59
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fe0a6b960611771b6765002a315c248da3c07e59

Author: Nanley Chery <nanley.g.chery at intel.com>
Date:   Thu Jan 13 15:16:40 2022 -0500

anv: Don't fill lowered_storage_image_param on SKL+

The switch statement in anv_descriptor_data_for_type() shows that this
field isn't used on SKL+.

On XeHP, this avoids assert failures by preventing
isl_surf_fill_image_param() from being called. That function doesn't
expect Tile4 surfaces.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14546>

---

 src/intel/vulkan/anv_image.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 8391c736a6a..a50bb4cf451 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -2671,6 +2671,7 @@ anv_CreateImageView(VkDevice _device,
                                          general_aux_usage, NULL,
                                          ANV_IMAGE_VIEW_STATE_STORAGE_LOWERED,
                                          &iview->planes[vplane].lowered_storage_surface_state,
+                                         device->info.ver >= 9 ? NULL :
                                          &iview->planes[vplane].lowered_storage_image_param);
          } else {
             /* In this case, we support the format but, because there's no



More information about the mesa-commit mailing list