Mesa (main): radv: fix computing the number of color samples if no attachments
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Jan 21 09:58:10 UTC 2022
Module: Mesa
Branch: main
Commit: b8c518f0fbf56faa4290062172790e111e86099b
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8c518f0fbf56faa4290062172790e111e86099b
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Jan 20 23:49:08 2022 +0100
radv: fix computing the number of color samples if no attachments
When no color attachments, the rasterization samples should be used.
Fixes: 0222dace909 ("radv: Support VK_KHR_dynamic_rendering for pipeline creation.")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5830
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14642>
---
src/amd/vulkan/radv_pipeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index fc4cde38ef2..17332ed42ab 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -870,7 +870,7 @@ radv_pipeline_color_samples(const VkGraphicsPipelineCreateInfo *pCreateInfo)
vk_find_struct_const(pCreateInfo->pNext, ATTACHMENT_SAMPLE_COUNT_INFO_AMD);
const VkPipelineRenderingCreateInfoKHR *render_create_info =
vk_find_struct_const(pCreateInfo->pNext, PIPELINE_RENDERING_CREATE_INFO_KHR);
- if (sample_info && render_create_info) {
+ if (sample_info && render_create_info && sample_info->colorAttachmentCount > 0) {
unsigned samples = 1;
for (uint32_t i = 0; i < sample_info->colorAttachmentCount; ++i) {
if (render_create_info->pColorAttachmentFormats[i] != VK_FORMAT_UNDEFINED) {
More information about the mesa-commit
mailing list