Mesa (main): intel/isl: Don't check pitch in isl_surf_get_mcs_surf

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jan 21 20:54:43 UTC 2022


Module: Mesa
Branch: main
Commit: bf9466e285128303ca92c527b60654e58ac622d5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bf9466e285128303ca92c527b60654e58ac622d5

Author: Nanley Chery <nanley.g.chery at intel.com>
Date:   Tue Dec  7 20:37:25 2021 -0500

intel/isl: Don't check pitch in isl_surf_get_mcs_surf

The pitch check for 16x multisampled surfaces should already be covered
by the pitch_in_range check in isl_calc_row_pitch.

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Acked-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14464>

---

 src/intel/isl/isl.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 996d042e1a9..dcc48b74ff3 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -2080,16 +2080,6 @@ isl_surf_get_mcs_surf(const struct isl_device *dev,
    if (ISL_GFX_VER(dev) == 7 && isl_format_has_sint_channel(surf->format))
       return false;
 
-   /* The "Auxiliary Surface Pitch" field in RENDER_SURFACE_STATE is only 9
-    * bits which means the maximum pitch of a compression surface is 512
-    * tiles or 64KB (since MCS is always Y-tiled).  Since a 16x MCS buffer is
-    * 64bpp, this gives us a maximum width of 8192 pixels.  We can create
-    * larger multisampled surfaces, we just can't compress them.   For 2x, 4x,
-    * and 8x, we have enough room for the full 16k supported by the hardware.
-    */
-   if (surf->samples == 16 && surf->logical_level0_px.width > 8192)
-      return false;
-
    enum isl_format mcs_format;
    switch (surf->samples) {
    case 2:  mcs_format = ISL_FORMAT_MCS_2X;  break;



More information about the mesa-commit mailing list