Mesa (main): zink: use a std430 interface for bo types

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jul 5 21:18:29 UTC 2022


Module: Mesa
Branch: main
Commit: 6759320c652fbc69fb74fb97bbcc980d80c5acef
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6759320c652fbc69fb74fb97bbcc980d80c5acef

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Wed Jun 29 19:23:45 2022 -0400

zink: use a std430 interface for bo types

no functional changes but is technically more correct

Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17239>

---

 src/gallium/drivers/zink/zink_compiler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/zink/zink_compiler.c b/src/gallium/drivers/zink/zink_compiler.c
index 128f1e5f16f..103b7e0ffbe 100644
--- a/src/gallium/drivers/zink/zink_compiler.c
+++ b/src/gallium/drivers/zink/zink_compiler.c
@@ -2185,7 +2185,7 @@ unbreak_bos(nir_shader *shader, struct zink_shader *zs, bool needs_size)
       if (shader->num_uniforms && zs->ubos_used & BITFIELD_BIT(0)) {
          fields[0].type = glsl_array_type(glsl_uint_type(), max_uniform_size * 4, 4);
          nir_variable *var = nir_variable_create(shader, nir_var_mem_ubo,
-                                                 glsl_array_type(glsl_struct_type(fields, 1, "struct", false), 1, 0),
+                                                 glsl_array_type(glsl_interface_type(fields, 1, GLSL_INTERFACE_PACKING_STD430, false, "struct"), 1, 0),
                                                  "uniform_0");
          var->interface_type = var->type;
          var->data.mode = nir_var_mem_ubo;



More information about the mesa-commit mailing list