Mesa (main): util: Use util_sign_extend in fast_idiv_by_const

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jul 6 12:09:28 UTC 2022


Module: Mesa
Branch: main
Commit: 1df29825e7dc46338ee5c7ccbdfdc2327beda427
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1df29825e7dc46338ee5c7ccbdfdc2327beda427

Author: Jason Ekstrand <jason.ekstrand at collabora.com>
Date:   Thu Jun 23 12:34:51 2022 -0500

util: Use util_sign_extend in fast_idiv_by_const

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Kristian H. Kristensen <hoegsberg at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17214>

---

 src/util/fast_idiv_by_const.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/src/util/fast_idiv_by_const.c b/src/util/fast_idiv_by_const.c
index b9f0b9cb760..26d69860065 100644
--- a/src/util/fast_idiv_by_const.c
+++ b/src/util/fast_idiv_by_const.c
@@ -169,12 +169,6 @@ util_compute_fast_udiv_info(uint64_t D, unsigned num_bits, unsigned UINT_BITS)
    return result;
 }
 
-static inline int64_t
-sign_extend(int64_t x, unsigned SINT_BITS)
-{
-   return (int64_t)((uint64_t)x << (64 - SINT_BITS)) >> (64 - SINT_BITS);
-}
-
 struct util_fast_sdiv_info
 util_compute_fast_sdiv_info(int64_t D, unsigned SINT_BITS)
 {
@@ -236,7 +230,7 @@ util_compute_fast_sdiv_info(int64_t D, unsigned SINT_BITS)
       delta = abs_d - remainder2;
    } while (quotient1 < delta || (quotient1 == delta && remainder1 == 0));
 
-   result.multiplier = sign_extend(quotient2 + 1, SINT_BITS);
+   result.multiplier = util_sign_extend(quotient2 + 1, SINT_BITS);
    if (D < 0) result.multiplier = -result.multiplier;
    result.shift = exponent - SINT_BITS;
    return result;



More information about the mesa-commit mailing list