Mesa (main): v3dv: remove unused lowering for nir_intrinsic_load_layer_id

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jul 12 12:07:14 UTC 2022


Module: Mesa
Branch: main
Commit: f286289c7fd1478529a90b910a84a467b559b283
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f286289c7fd1478529a90b910a84a467b559b283

Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Tue Jul 12 11:36:56 2022 +0200

v3dv: remove unused lowering for nir_intrinsic_load_layer_id

This intrinsic is only produced when the compiler is instructed
to handle layer id as a system value, which we don't use. Also,
we have been supporting layered rendering for a while and passing
all the relevant tests which would've failed if we were hitting
this lowering.

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17483>

---

 src/broadcom/vulkan/v3dv_pipeline.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/broadcom/vulkan/v3dv_pipeline.c b/src/broadcom/vulkan/v3dv_pipeline.c
index 65a4507e4db..60e45d281df 100644
--- a/src/broadcom/vulkan/v3dv_pipeline.c
+++ b/src/broadcom/vulkan/v3dv_pipeline.c
@@ -883,15 +883,6 @@ lower_intrinsic(nir_builder *b, nir_intrinsic_instr *instr,
                 const struct v3dv_pipeline_layout *layout)
 {
    switch (instr->intrinsic) {
-   case nir_intrinsic_load_layer_id:
-      /* FIXME: if layered rendering gets supported, this would need a real
-       * lowering
-       */
-      nir_ssa_def_rewrite_uses(&instr->dest.ssa,
-                               nir_imm_int(b, 0));
-      nir_instr_remove(&instr->instr);
-      return true;
-
    case nir_intrinsic_load_push_constant:
       lower_load_push_constant(b, instr, pipeline);
       return true;



More information about the mesa-commit mailing list