Mesa (main): etnaviv: tex_desc: remove descriptor patch TODO comment

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: 0d13dfcf7c188f2f83e1e3a0405f867e3ed3054c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0d13dfcf7c188f2f83e1e3a0405f867e3ed3054c

Author: Lucas Stach <l.stach at pengutronix.de>
Date:   Sun Jul 10 16:37:25 2022 +0200

etnaviv: tex_desc: remove descriptor patch TODO comment

There is nothing more TODO here. With softpin, which is available on all
GPUs using texture descriptors, there is no need for the kernel to patch
the descriptor, as the proper GPU virtual address is filled in by userspace.

Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
Reviewed-by: Philipp Zabel <p.zabel at pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17448>

---

 src/gallium/drivers/etnaviv/etnaviv_texture_desc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c b/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c
index beb932ccde9..8e2a7632afb 100644
--- a/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c
+++ b/src/gallium/drivers/etnaviv/etnaviv_texture_desc.c
@@ -230,14 +230,12 @@ etna_sampler_view_update_descriptor(struct etna_context *ctx,
                                     struct etna_cmd_stream *stream,
                                     struct etna_sampler_view_desc *sv)
 {
-   /* TODO: this should instruct the kernel to update the descriptor when the
-    * bo is submitted. For now, just prevent the bo from being freed
-    * while it is in use indirectly.
-    */
    struct etna_resource *res = etna_resource(sv->base.texture);
+
    if (res->texture) {
       res = etna_resource(res->texture);
    }
+
    /* No need to ref LOD levels individually as they'll always come from the same bo */
    etna_cmd_stream_ref_bo(stream, res->bo, ETNA_RELOC_READ);
 }