Mesa (22.1): 31 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Jul 15 17:36:41 UTC 2022
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cc8a8ebfe970a073573868f445ab38267d67ea59
Author: Jason Ekstrand <jason.ekstrand at collabora.com>
Date: Mon Jun 13 16:13:07 2022 -0500
anv: Stop compacting surface state tables
Instead of trying to compact the surface state table to get rid of any
unused render targets, emit MAX(1, colorAttachmentCount) surface states
always. This ensures that secondaries will always match with primaries
when we go to do the copy since there's no rule requiring the secondary
to have VK_FORMAT_UNDEFINED when the primary has a NULL image view.
Fixes: 3501a3f9ed92 ("anv: Convert to 100% dynamic rendering")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17013>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2dfe188468f5623c36d0fe62ce08b82a4235b0c2
Author: Jason Ekstrand <jason.ekstrand at collabora.com>
Date: Mon Jun 13 16:17:23 2022 -0500
anv: Inheritance info cannot be NULL
The NULL path is dead because it can't actually be NULL. This cleans
things up a bit.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17013>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6ddbd56174bd8eab4711be59ccb2ccd392b57b2f
Author: Emma Anholt <emma at anholt.net>
Date: Mon Jul 11 15:50:50 2022 -0700
zink: Do the timestamp-to-ns math in a double to have better precision.
Fixes arb_timer_query-timestamp-get on my radv system, where the GPU has
been on for many days and the timestamp would only increment every once in
a while.
Part of fixing #6808
Fixes: 7a40b734ee2b ("zink: handle timestamp queries")
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17477>
(cherry picked from commit 0feedec9e6b630f930605d9681911fe9e2b705ce)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cf26e274c728925fac9d3b0d8664651452a783af
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Mon Jul 11 15:04:00 2022 -0400
lavapipe: don't crash on null xfb buffer pointer
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17469>
(cherry picked from commit fb917a606cf9cc50b40e06730f296a092db82c51)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3f76b2a272fb01147bc274398400a48fc37d5ecd
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Mon Jul 11 10:59:00 2022 -0400
lavapipe: don't overwrite entire VkFormatProperties3 struct
this clobbers pNext and breaks tooling, as found by Panagiotis Apostolou
Fixes: f72d5a930b1 ("lavapipe: KHR_format_feature_flags2")
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17462>
(cherry picked from commit 276557b9c6261a26fb11932c8e51faf23893f482)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=56b7c79ccff6cf9c3889e5e6fbdbe4f63c799db6
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Fri Jul 1 10:43:21 2022 +0300
isl: add new helper for format component compatibility
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17329>
(cherry picked from commit ab4beaf3fb015fce743acac9efb933c110881bf5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9276b2f2f3223728683b3aa0e89b9e702028f083
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Thu Jul 7 12:27:08 2022 +0200
aco: fix packed 16bit fneg/fsat optimization
Make sure that the Operand is '1.0.xx'.
Fixes: b03be30e07546b813acc1156407b964e68892beb ('aco: optimize packed fneg')
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17395>
(cherry picked from commit 66d46a23fbc289b9492547697f0738f32ecb46c8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8a4456348605fffd1e1b781f8e5a4e09ec74392c
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Fri Jul 8 12:57:32 2022 +0200
radv/shader_info: fix load_frag_coord and load_sample_pos read masks
Fixes: a8c471f962e3a86f0cb6a91f14090b0c8cfb73ff ('radv: gather more information about PS in the shader info pass')
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17417>
(cherry picked from commit 676700d660c8b5ead660b2c694fafde0a57c635d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a18fe9357012bf21d7f17c06f6467ba079d7eac2
Author: Pavel Ondračka <pavel.ondracka at gmail.com>
Date: Thu Jul 7 10:44:41 2022 +0200
r300: Keep rc_rename_regs() from overflowing RC_REGISTER_MAX_INDEX
This pass tries to move register usage closer to SSA, and for large
shaders this means we can overflow the register index, which only has
RC_REGISTER_INDEX_BITS size. This creates invalid code and leads to
crash at a later stage. Limit the pool of available registers to
RC_REGISTER_MAX_INDEX, currently is was two times the number of
shader instructions.
This means we'll fail the compile right away if we wanted more than
RC_REGISTER_MAX_INDEX temps, but when we've got that many we're
already well past how many instructions we can support anyway.
CC: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6017
Signed-off-by: Pavel Ondračka <pavel.ondracka at gmail.com>
Reviewed-by: Emma Anholt <emma at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17393>
(cherry picked from commit 42a3d22f165a990ba3e05ef7e8e5d147f62281b4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1678100c3c64724ac2462739c10fe92976f8a40b
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Wed Jul 6 12:21:34 2022 -0400
mesa: fix SignalSemaphoreEXT behavior
the EXT_external_object spec originally was underspecified with regards
to this function, leaving room for synchronization errors where:
* app calls SignalSemaphoreEXT to signal a semaphore
* mesa defers pipe_context::fence_server_signal with threaded context
* driver defers gpu submission
* SignalSemaphoreEXT has long since returned, app submits vk cmdbuf waiting on semaphore
* spec violation / device lost
to prevent this, the spec is being changed to:
1) require an implicit flush when calling SignalSemaphoreEXT
2) require that this implicit flush also forces GPU submission before SignalSemaphoreEXT returns
all affected drivers have been updated
fixes #6568
cc: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17376>
(cherry picked from commit 21b3a234048a270e7999f8e70e25091c599dd3eb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4514fdff785b43cba7db7618c2abbadcaf6e767f
Author: Marek Olšák <marek.olsak at amd.com>
Date: Wed Jun 29 15:18:55 2022 -0400
radeonsi: fix random PS wave size
Fixes: b3b2f97f2e25b2c "radeonsi: add Wave32 heuristics and shader profiles"
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17410>
(cherry picked from commit 3b36700162c8a3a950e930714003d60ba672db8c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6da016cded42114f1c31e367fc4643ff8aefce80
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Wed Apr 20 18:28:28 2022 +0300
nir/serialize: restore ray query variables
The ray query status of a variable is tracked in the
nir_variable::data. We need to store it in the serialization otherwise
restoring NIR from a cache will drop the annotation.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 5a9cdab17050 ("nir: track variables representing ray queries")
Reviewed-by: Caio Oliveira <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16059>
(cherry picked from commit a4c5521ea9b1852734672e1978ff769a1e11113f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=95d522f4757107bb64ee487bdbb89833cbcf7edf
Author: Tatsuyuki Ishi <ishitatsuyuki at gmail.com>
Date: Tue May 10 13:44:05 2022 +0900
radv: Fix vkCmdCopyQueryResults -> vkCmdResetPool hazard.
The Vulkan specification states:
> Query commands, for the same query and submitted to the same queue,
> execute in their entirety in submission order, relative to each other. In
> effect there is an implicit execution dependency from each such query
> command to all query commands previously submitted to the same queue.
Fixes dEQP-VK.query_pool.statistics_query.reset_after_copy.*
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17400>
(cherry picked from commit 768cd5715def2ee69b5084e9da83fcbe3228cdaa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=09588251ffe8842cdc71bdcd70563bc5c68d7fdc
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date: Fri Jun 17 16:40:32 2022 -0400
panfrost: Clear with a quad to avoid flushing
Flushing the batch midframe (splitting a renderpass) is expensive on a tiler, as
it requires the GPU to flush the framebuffer contents to main memory and read
them back. Clearing the framebuffer should not trigger a flush. Apps expect
clears to be (almost) free, flushing for a clear is at the very least unexpected
behaviour.
The only reason we previously flushed is to ensure we could always use a "fast"
clear. But a slow clear is a heck of a lot faster than a flush ;-) Instead of
flushing, we should clear with a draw (via u_blitter) in case a fast clear isn't
possible.
This fixes pathological performance for applications that rely on partial clears
within a frame. This issue was identified with Inochi2D, which repeatedly clears
the stencil buffer midframe, in order to implement masking efficiently with the
stencil buffer. In total, the all-important workload of rendering Asahi Lina is
improved from 17fps to 29fps on a panfrost device.
Fixes: c138ca80d23 ("panfrost: Make sure a clear does not re-use a pre-existing batch")
Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17112>
(cherry picked from commit 638b22354e75fa31551f776a2cd2bbf752db1ad5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0869e0aac5f206dca9d41edd7667c258b9d8a10f
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Thu Jun 23 14:15:51 2022 +0300
intel/fs: ray query fix for global address
With stages dispatching with a mask, we can run into situations where
we don't have the global address in all lanes. The existing code
always assumed we had the addres in at least lane0.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: bb40e999d114 ("intel/nir: use a single intel intrinsic to deal with ray traversal")
Reviewed-by: Caio Oliveira <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17330>
(cherry picked from commit 9680e0e4a2d1f7f5490ea27e4c5250baa2f21d48)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fcb327dd37049c09fde161020c1591895478f24c
Author: Jason Ekstrand <jason.ekstrand at collabora.com>
Date: Wed Jul 6 19:30:11 2022 -0500
vulkan/wsi/x11: Don't leak shm_reply if we don't have dri3 or present
Fixes: b5c390c113d3 ("vulkan/wsi: add support for detecting mit-shm pixmaps.")
Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388>
(cherry picked from commit 5abc05f1df44dd9ee2f054729b2bdf01a5e45e33)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2b157e92d75cafb39b64ab19e26c3c57a06de1e0
Author: Jason Ekstrand <jason.ekstrand at collabora.com>
Date: Tue Jul 5 17:24:50 2022 -0500
vulkan/wsi: Pass the size to MapMemory in the SW path
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17388>
(cherry picked from commit ca6bd57e7643358fefd766883c8bb323e48777f3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=eb1fb9305d744a29d5772c34faa5086dca0a8c1c
Author: Iago Toral Quiroga <itoral at igalia.com>
Date: Thu Jul 7 11:13:51 2022 +0200
nir: fix documentation for uadd_carry and usub_borry opcodes
These opcodes where fixed to return an integer instead of a boolean
value some time ago but the documentation for them was not updated
and still talked about a boolean result.
Fixes: b0d4ee520 ('nir/opcodes: Fix up uadd_carry and usub_borrow')
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17372>
(cherry picked from commit 84a0dca9dffebe7927a388d95ca620d3677acb30)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0fec632102336907cbb01803335939d7c1d74a40
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Jul 12 10:15:57 2022 -0700
.pick_status.json: Update to 0feedec9e6b630f930605d9681911fe9e2b705ce
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=562c1d93b312a94d2a51652377b9ca73a721eab7
Author: Lionel Landwerlin <llandwerlin at gmail.com>
Date: Sun Jun 12 22:18:45 2022 +0300
anv: use the right helper to invalidate memory
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Caio Oliveira <caio.oliveira at intel.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17001>
(cherry picked from commit b91971c240d3b8391f2105337579a0e14116769c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=122e31b5ea580f2fc87a1582d2bafae66cbb4795
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date: Tue Jun 21 13:00:42 2022 -0400
ttn: Set nir->info.separate_shader
TGSI has no legitimate[1] notion of linked shaders, which means tgsi_to_nir
should conservatively assume everything all shaders are separable. This requires
setting nir->info.separate_shader to warn drivers that shader CSOs might be
mixed and matched. Otherwise, the driver might enable optimizations that
are invalid for separate shaders, causing issues when the shaders are
later treated as separable.
This will fix varying linking with u_blitter's shaders on Panfrost (Bifrost and
older), when util_blitter_clear is used with Panfrost.
[1] There was a TGSI property added recently to forward
nir->info.separate_shader up to virglrenderer, but it's not actually used for
anything in virglrenderer and I am still struggling to understand what the use
case would be. My gut says we should revert b63403054237 ("tgsi: Add
SEPARABLE_PROGRAM property"), but I'm not interested in fighting that yak right
now. Notably, the u_blitter and hud shaders are separable but are not marked
with this property.
Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Reviewed-by: Emma Anholt <emma at anholt.net>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17282>
(cherry picked from commit 151aa19c21575ba498a19c48e84474107a4eb304)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=af9b75331879e14920631187e4347ff22fa907ba
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Tue Jun 28 11:13:54 2022 +0200
nir/opt_shrink_vectors: fix re-using of components for vecN
Cc: mesa-stable
Reviewed-by: Emma Anholt <emma at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17276>
(cherry picked from commit 862f1eacb2dc68dd099f8c923134ab01b4459538)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e1cf74f53bfbaa5af4d976ea8274e3b837b7cf6b
Author: Iago Toral Quiroga <itoral at igalia.com>
Date: Thu Jun 30 13:34:32 2022 +0200
v3dv: fix pool descriptor count for inline uniform buffers
Fixes VK_ERROR_OUT_OF_POOL_MEMORY in the inlineuniformblocks
sample from Sascha Willems.
Fixes: ea3223e7a46 ('v3dv: implement VK_EXT_inline_uniform_block')
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17311>
(cherry picked from commit 7b91b39ba517d8bccf3c44007d1acfaf4fac84c0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=040658cd26477892977f48a2dbf0469c780ce9ab
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Thu Jun 30 13:54:42 2022 -0400
zink: enforce viewport depth clamping
VUID-VkViewport-minDepth-01234 specifies that depth must be in the range [0.0, 1.0],
so the viewport must always be clamped to this range
this affects texture clears using u_blitter, as this expects to be able
to use the GL range of [-1.0, 1.0], so pass the depth value as though it's
been de-converted back to a GL z coordinate to account for viewport transform
cc: mesa-stable
fixes #6757
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17319>
(cherry picked from commit 90c5eea22b69306e463decd405029944b4a0d53b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a9b3df51e026a4c5691cbd431d081ed9c7d16fe5
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Jun 29 14:13:38 2022 +0100
aco/ra: update register file when updating phi definition
update_renames() fills in the wrong temp id.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Fixes: 302cb5c9001 ("aco/ra: remove some redundant code")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17295>
(cherry picked from commit 84f04fd0800384306347277c4e39524f0b295e34)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a80fe86c5c42fe15b822425c6f939162122f88e6
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Jul 6 10:00:44 2022 -0700
.pick_status.json: Update to 9dbfc21ab9ac99ebec56369d1e1ea9d7b615d5f5
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a066287f1b5c88a47b6c8af9dcf0a110559e8a48
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Fri Jun 24 11:15:50 2022 -0400
nir/types: fix glsl_matrix_type_is_row_major() assert
interface blocks can have row_major set
cc: mesa-stable
affects (zink):
dEQP-GLES2.functional.shaders*
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Reviewed-by: Jason Ekstrand <jason.ekstrand at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17238>
(cherry picked from commit 0e7863c3b025042d7e41b5c9f73a6b7f788a87a3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7d4d33e858df91270c0e1a7e8bc6e4b2145f611a
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Thu Jun 30 08:58:34 2022 -0700
.pick_status.json: Update to 8ab1e9826db5936ff287bef7b428ebee27ada507
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f6fdddf385235f1b9b54273b5c9afd5b2c31e85
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Jun 29 15:36:48 2022 -0700
.pick_status.json: Mark 4480e577a462d43f5c7701d2c1b70c601c626e18 as denominated
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2a453ba93f2e8529af70666386a6e4bc60ee704f
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Thu Jun 23 10:33:33 2022 +0300
anv: disable non uniform indexing of UBOs
The feature we wanted to enable in 710393b3aa4a was
descriptorBindingUniformBufferUpdateAfterBind.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 710393b3aa4a ("anv: enable UBO indexing")
Reviewed-by: Francisco Jerez <currojerez at riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17200>
(cherry picked from commit 3e247cd05f30b963027bd5e9ffcadf2cfa27ff5b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=05d8bc7f818303dbd500162fae873a52c2dc90f5
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Jun 29 15:34:11 2022 -0700
.pick_status.json: Update to c017dfec62e448fea9ad9d16c575086b0de19b3b
More information about the mesa-commit
mailing list