Mesa (main): aco: Initialize spill_ctx members in constructor.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jul 20 14:02:59 UTC 2022


Module: Mesa
Branch: main
Commit: 7384aab3ee5b84b60c24979e0e17405eb9d5e31c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7384aab3ee5b84b60c24979e0e17405eb9d5e31c

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Sun Jul 17 14:15:57 2022 -0700

aco: Initialize spill_ctx members in constructor.

Fix defects reported by Coverity Scan.

Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member sgpr_spill_slots is not
initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member vgpr_spill_slots is not
initialized in this constructor nor in any functions that it calls.

Fixes: 7d340449086 ("aco: refactor VGPR spill/reload lowering")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Timur Kristóf <timur.kristof at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17583>

---

 src/amd/compiler/aco_spill.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/amd/compiler/aco_spill.cpp b/src/amd/compiler/aco_spill.cpp
index 4b1099e8b28..e712920f53e 100644
--- a/src/amd/compiler/aco_spill.cpp
+++ b/src/amd/compiler/aco_spill.cpp
@@ -91,7 +91,8 @@ struct spill_ctx {
        : target_pressure(target_pressure_), program(program_),
          register_demand(std::move(register_demand_)), renames(program->blocks.size()),
          spills_entry(program->blocks.size()), spills_exit(program->blocks.size()),
-         processed(program->blocks.size(), false), wave_size(program->wave_size)
+         processed(program->blocks.size(), false), wave_size(program->wave_size),
+         sgpr_spill_slots(0), vgpr_spill_slots(0)
    {}
 
    void add_affinity(uint32_t first, uint32_t second)



More information about the mesa-commit mailing list