Mesa (main): iris/bufmgr: Add assert and TODO comment for future small BAR uapi

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jul 21 20:54:55 UTC 2022


Module: Mesa
Branch: main
Commit: 85099804bf85f042fed7a08324cf2982940988c3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=85099804bf85f042fed7a08324cf2982940988c3

Author: Jordan Justen <jordan.l.justen at intel.com>
Date:   Tue Jun 21 15:12:18 2022 -0700

iris/bufmgr: Add assert and TODO comment for future small BAR uapi

Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

---

 src/gallium/drivers/iris/iris_bufmgr.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/gallium/drivers/iris/iris_bufmgr.c b/src/gallium/drivers/iris/iris_bufmgr.c
index e04712a2540..897f333346e 100644
--- a/src/gallium/drivers/iris/iris_bufmgr.c
+++ b/src/gallium/drivers/iris/iris_bufmgr.c
@@ -997,6 +997,12 @@ alloc_fresh_bo(struct iris_bufmgr *bufmgr, uint64_t bo_size, unsigned flags)
          .extensions = (uintptr_t)&ext_regions,
       };
 
+      /* TODO: Add I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS to create.flags
+       * for IRIS_HEAP_DEVICE_LOCAL_PREFERRED when small BAR uapi is
+       * stabilized.
+       */
+      assert(bufmgr->all_vram_mappable);
+
       /* It should be safe to use GEM_CREATE_EXT without checking, since we are
        * in the side of the branch where discrete memory is available. So we
        * can assume GEM_CREATE_EXT is supported already.



More information about the mesa-commit mailing list