Mesa (main): zink: drop pointless comment

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jul 22 09:02:38 UTC 2022


Module: Mesa
Branch: main
Commit: 89f77144d79e167b2a22d7808665d870657703ee
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=89f77144d79e167b2a22d7808665d870657703ee

Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date:   Thu Jul 21 12:22:43 2022 +0200

zink: drop pointless comment

We're already handling all the meaningful types here. The other types
like samplers, images, structs etc aren't really appropriate here.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17676>

---

 src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c b/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c
index 8b53bead788..ee29d6735a8 100644
--- a/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c
+++ b/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c
@@ -377,7 +377,6 @@ get_glsl_basetype(struct ntv_context *ctx, enum glsl_base_type type)
       return spirv_builder_type_int(&ctx->builder, 8);
    case GLSL_TYPE_UINT8:
       return spirv_builder_type_uint(&ctx->builder, 8);
-   /* TODO: handle more types */
 
    default:
       unreachable("unknown GLSL type");



More information about the mesa-commit mailing list