Mesa (main): intel/eu: Mark header present in URB memory fences on XeHP

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jul 28 22:07:37 UTC 2022


Module: Mesa
Branch: main
Commit: fc02ce57131c3edd462d093e7e4f842bf93315db
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fc02ce57131c3edd462d093e7e4f842bf93315db

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Mon Jul 18 16:48:39 2022 -0700

intel/eu: Mark header present in URB memory fences on XeHP

Fixes the following EU validation error:

   ERROR: Header must be present for all URB messages.

The message header is ignored for URB fence messages, so I doubt that
this actually matters in practice.  But we should probably mark it as
present, because you have to send something, and according to the
documentation, there is a message header, it's just ignored.

Fixes: e6a9501aa27 ("intel/fs: Add the URB fence message")
Reviewed-by: Francisco Jerez <currojerez at riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17624>

---

 src/intel/compiler/brw_eu_emit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c
index 28360abed70..4507ade3a1a 100644
--- a/src/intel/compiler/brw_eu_emit.c
+++ b/src/intel/compiler/brw_eu_emit.c
@@ -3268,7 +3268,7 @@ gfx12_set_memory_fence_message(struct brw_codegen *p,
 
    if (sfid == BRW_SFID_URB) {
       brw_set_desc(p, insn, brw_urb_fence_desc(p->devinfo) |
-                            brw_message_desc(p->devinfo, mlen, rlen, false));
+                            brw_message_desc(p->devinfo, mlen, rlen, true));
    } else {
       enum lsc_fence_scope scope = lsc_fence_msg_desc_scope(p->devinfo, desc);
       enum lsc_flush_type flush_type = lsc_fence_msg_desc_flush_type(p->devinfo, desc);



More information about the mesa-commit mailing list