Mesa (main): d3d12: Remove unnecessary NULL check.

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: 6dfaedd607d7e174226b17f56cf9310f8c1f79c0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6dfaedd607d7e174226b17f56cf9310f8c1f79c0

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Wed May 25 16:49:31 2022 -0700

d3d12: Remove unnecessary NULL check.

Fix defect reported by Coverity Scan.

Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking pD3D12VideoBuffer suggests that it may
be null, but it has already been dereferenced on all paths leading to
the check.

Fixes: d8206f62865 ("d3d12: Add video decode implementation of pipe_video_codec")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16714>

---

 src/gallium/drivers/d3d12/d3d12_video_buffer.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/gallium/drivers/d3d12/d3d12_video_buffer.cpp b/src/gallium/drivers/d3d12/d3d12_video_buffer.cpp
index a6e0be37a64..ad51a93d1f4 100644
--- a/src/gallium/drivers/d3d12/d3d12_video_buffer.cpp
+++ b/src/gallium/drivers/d3d12/d3d12_video_buffer.cpp
@@ -105,9 +105,7 @@ d3d12_video_buffer_create(struct pipe_context *pipe, const struct pipe_video_buf
    return &pD3D12VideoBuffer->base;
 
 failed:
-   if (pD3D12VideoBuffer != nullptr) {
-      d3d12_video_buffer_destroy((struct pipe_video_buffer *) pD3D12VideoBuffer);
-   }
+   d3d12_video_buffer_destroy((struct pipe_video_buffer *) pD3D12VideoBuffer);
 
    return nullptr;
 }