Mesa (main): pan/mdg: Remove uppercase write masks

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: 8c11f4809b8c766902ad5ac36d2dd5c0536ce682
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8c11f4809b8c766902ad5ac36d2dd5c0536ce682

Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Thu May 19 12:08:46 2022 -0400

pan/mdg: Remove uppercase write masks

These do not convey any additional information, and fail to account for
shrinking. In particular, a 64-bit writemask with .keephi would fail to
disassemble and instead trip the assertion, since that would be the ZW
components. Just delete the broken code.

Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16798>

---

 src/panfrost/midgard/disassemble.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/panfrost/midgard/disassemble.c b/src/panfrost/midgard/disassemble.c
index 98cdf66cb9e..a3f54fdfdb9 100644
--- a/src/panfrost/midgard/disassemble.c
+++ b/src/panfrost/midgard/disassemble.c
@@ -737,7 +737,6 @@ print_alu_mask(FILE *fp, uint8_t mask, unsigned bits, midgard_shrink_mode shrink
         fprintf(fp, ".");
 
         unsigned skip = MAX2(bits / 16, 1);
-        bool uppercase = bits > 32;
         bool tripped = false;
 
         /* To apply an upper destination shrink_mode, we "shift" the alphabet.
@@ -764,11 +763,6 @@ print_alu_mask(FILE *fp, uint8_t mask, unsigned bits, midgard_shrink_mode shrink
                         unsigned comp_idx = bits == 8 ? i * 2 : i;
                         char c = alphabet[comp_idx / skip];
 
-                        if (uppercase) {
-                                c = toupper(c);
-                                assert(c == 'X' || c == 'Y');
-                        }
-
                         fprintf(fp, "%c", c);
                         if (bits == 8)
                                 fprintf(fp, "%c", alphabet[comp_idx+1]);