Mesa (staging/22.0): zink: require draw params ext/cap in ntv if drawid is used

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 1 20:58:20 UTC 2022


Module: Mesa
Branch: staging/22.0
Commit: fbf27641f65329b7fd1e3e62291cd858595e09cc
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fbf27641f65329b7fd1e3e62291cd858595e09cc

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Fri May 27 16:16:04 2022 -0400

zink: require draw params ext/cap in ntv if drawid is used

cc: mesa-stable

Reviewed-by: Jason Ekstrand <jason.ekstrand at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16757>
(cherry picked from commit 591da8cf5d6bd87067059228bbf8dac83922e47e)

---

 .pick_status.json                                    | 2 +-
 src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.pick_status.json b/.pick_status.json
index 3de34717359..085215a7ebe 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -820,7 +820,7 @@
         "description": "zink: require draw params ext/cap in ntv if drawid is used",
         "nominated": true,
         "nomination_type": 0,
-        "resolution": 0,
+        "resolution": 1,
         "because_sha": null
     },
     {
diff --git a/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c b/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c
index 8812e0c3a11..0b1e179e468 100644
--- a/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c
+++ b/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c
@@ -3732,6 +3732,7 @@ nir_to_spirv(struct nir_shader *s, const struct zink_shader_info *sinfo, uint32_
 
    case MESA_SHADER_VERTEX:
       if (BITSET_TEST(s->info.system_values_read, SYSTEM_VALUE_INSTANCE_ID) ||
+          BITSET_TEST(s->info.system_values_read, SYSTEM_VALUE_DRAW_ID) ||
           BITSET_TEST(s->info.system_values_read, SYSTEM_VALUE_BASE_INSTANCE) ||
           BITSET_TEST(s->info.system_values_read, SYSTEM_VALUE_BASE_VERTEX)) {
          spirv_builder_emit_extension(&ctx.builder, "SPV_KHR_shader_draw_parameters");



More information about the mesa-commit mailing list