Mesa (main): radv: Remove usage of `cnd_monotonic.h`

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jun 3 07:13:10 UTC 2022


Module: Mesa
Branch: main
Commit: 1d3727bcc6f47c550302581f2ff73bb730438fcd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1d3727bcc6f47c550302581f2ff73bb730438fcd

Author: Yonggang Luo <luoyonggang at gmail.com>
Date:   Sat Apr  9 21:53:03 2022 +0800

radv: Remove usage of `cnd_monotonic.h`

Improve: 91fe0b5629d ("radv: Delete lots of sync code.")

As cnd_monotonic.h are include `util/os_time.h`, radv_debug.c and radv_debug.c needs `util/os_time.h`
So include in these files directly.

The compiling errors are:
```
../src/amd/vulkan/radv_debug.c:707:12: error: implicit declaration of function 'os_localtime' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
   timep = os_localtime(&raw_time, &result);

../src/amd/vulkan/radv_device.c:97:11: error: implicit declaration of function 'os_time_get_nano' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
   return os_time_get_nano();
          ^

../../src/amd/vulkan/radv_pipeline.c: In function 'radv_create_shaders':
../../src/amd/vulkan/radv_pipeline.c:4119:29: error: implicit declaration of function 'os_time_get_nano' [-Werror=implicit-function-declaration]
 4119 |    int64_t pipeline_start = os_time_get_nano();
```

Signed-off-by: Yonggang Luo <luoyonggang at gmail.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Reviewed-by: Jason Ekstrand <jason.ekstrand at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16536>

---

 src/amd/vulkan/radv_debug.c    | 1 +
 src/amd/vulkan/radv_device.c   | 1 +
 src/amd/vulkan/radv_pipeline.c | 1 +
 src/amd/vulkan/radv_private.h  | 1 -
 4 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c
index 329e8c642d2..4da13f612a7 100644
--- a/src/amd/vulkan/radv_debug.c
+++ b/src/amd/vulkan/radv_debug.c
@@ -33,6 +33,7 @@
 #include <sys/stat.h>
 
 #include "util/mesa-sha1.h"
+#include "util/os_time.h"
 #include "ac_debug.h"
 #include "radv_debug.h"
 #include "radv_shader.h"
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index d7f552837b5..830516c157d 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -63,6 +63,7 @@ typedef void *drmDevicePtr;
 #include "util/debug.h"
 #include "util/driconf.h"
 #include "util/mesa-sha1.h"
+#include "util/os_time.h"
 #include "util/timespec.h"
 #include "util/u_atomic.h"
 #include "winsys/null/radv_null_winsys_public.h"
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index e79d0254a43..efcc3fb0a0c 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -30,6 +30,7 @@
 #include "spirv/nir_spirv.h"
 #include "util/disk_cache.h"
 #include "util/mesa-sha1.h"
+#include "util/os_time.h"
 #include "util/u_atomic.h"
 #include "radv_cs.h"
 #include "radv_debug.h"
diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h
index e8d4f84c160..898cb3a6778 100644
--- a/src/amd/vulkan/radv_private.h
+++ b/src/amd/vulkan/radv_private.h
@@ -49,7 +49,6 @@
 #endif
 #include "compiler/shader_enums.h"
 #include "util/bitscan.h"
-#include "util/cnd_monotonic.h"
 #include "util/list.h"
 #include "util/macros.h"
 #include "util/rwlock.h"



More information about the mesa-commit mailing list