Mesa (main): mesa: improve relocation problem message

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sat Jun 4 04:41:57 UTC 2022


Module: Mesa
Branch: main
Commit: 3ec74cd1c7ddafe18cb8318aeb981964d15acd1f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3ec74cd1c7ddafe18cb8318aeb981964d15acd1f

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Fri Jun  3 09:36:46 2022 -0400

mesa: improve relocation problem message

make it easier to immediately know what the problem is

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16851>

---

 src/mesa/program/prog_parameter.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/mesa/program/prog_parameter.c b/src/mesa/program/prog_parameter.c
index 5c895d5d3e3..35d3e5906ad 100644
--- a/src/mesa/program/prog_parameter.c
+++ b/src/mesa/program/prog_parameter.c
@@ -204,8 +204,10 @@ _mesa_reserve_parameter_storage(struct gl_program_parameter_list *paramList,
    if (paramList->DisallowRealloc &&
        (oldNum + reserve_params > paramList->Size ||
         needSizeValues > paramList->SizeValues)) {
-      _mesa_problem(NULL, "Parameter storage reallocation disallowed. This "
-              "is a Mesa bug. Increase the reservation size in the code.");
+      _mesa_problem(NULL, "Parameter storage reallocation disallowed.\n"
+                          "This is a Mesa bug.\n"
+                          "Increase the reservation size in the code (wanted bytes %u, have %u || wanted values %u have %u).",
+                          oldNum + reserve_params, paramList->Size, needSizeValues, paramList->SizeValues);
       abort();
    }
 



More information about the mesa-commit mailing list