Mesa (main): pan/va: Unit test constant lowering pass
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Jun 6 18:22:58 UTC 2022
Module: Mesa
Branch: main
Commit: 28801cfba03f6dfbfacd3061371c214ff23fd905
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=28801cfba03f6dfbfacd3061371c214ff23fd905
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date: Thu Jun 2 14:50:39 2022 -0400
pan/va: Unit test constant lowering pass
Like other optimizations, breaking this pass may not affect functional
correctness. It's also dead simple to unit test the pass, so we have no excuse
not to. Add unit tests for the functionality we currently support, since we just
extended it and want to make sure everything still works.
This includes tests for use of modifiers to get more small constants. There are
lots of subtle gotchas there, so let's add lots of unit tests to make sure we
got it right.
Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16862>
---
src/panfrost/bifrost/meson.build | 1 +
.../bifrost/valhall/test/test-lower-constants.cpp | 190 +++++++++++++++++++++
2 files changed, 191 insertions(+)
diff --git a/src/panfrost/bifrost/meson.build b/src/panfrost/bifrost/meson.build
index f485961366d..5a679a6c952 100644
--- a/src/panfrost/bifrost/meson.build
+++ b/src/panfrost/bifrost/meson.build
@@ -173,6 +173,7 @@ if with_tests
'valhall/test/test-validate-fau.cpp',
'valhall/test/test-insert-flow.cpp',
'valhall/test/test-lower-isel.cpp',
+ 'valhall/test/test-lower-constants.cpp',
'valhall/test/test-merge-flow.cpp',
'valhall/test/test-packing.cpp',
),
diff --git a/src/panfrost/bifrost/valhall/test/test-lower-constants.cpp b/src/panfrost/bifrost/valhall/test/test-lower-constants.cpp
new file mode 100644
index 00000000000..6bd3293c995
--- /dev/null
+++ b/src/panfrost/bifrost/valhall/test/test-lower-constants.cpp
@@ -0,0 +1,190 @@
+/*
+ * Copyright (C) 2021 Collabora, Ltd.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+#include "va_compiler.h"
+#include "bi_test.h"
+#include "bi_builder.h"
+
+#include <gtest/gtest.h>
+
+static inline void
+add_imm(bi_context *ctx)
+{
+ bi_foreach_instr_global(ctx, I) {
+ va_lower_constants(ctx, I);
+ }
+}
+
+#define CASE(instr, expected) INSTRUCTION_CASE(instr, expected, add_imm)
+
+class LowerConstants : public testing::Test {
+protected:
+ LowerConstants() {
+ mem_ctx = ralloc_context(NULL);
+ }
+
+ ~LowerConstants() {
+ ralloc_free(mem_ctx);
+ }
+
+ void *mem_ctx;
+};
+
+TEST_F(LowerConstants, Float32) {
+ CASE(bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_imm_f32(0.0)),
+ bi_fadd_f32_to(b, bi_register(0), bi_register(0), va_lut(0)));
+
+ CASE(bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_imm_f32(1.0)),
+ bi_fadd_f32_to(b, bi_register(0), bi_register(0), va_lut(16)));
+
+ CASE(bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_imm_f32(0.1)),
+ bi_fadd_f32_to(b, bi_register(0), bi_register(0), va_lut(17)));
+}
+
+TEST_F(LowerConstants, WidenFloat16) {
+ CASE(bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_imm_f32(0.5)),
+ bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_half(va_lut(26), 1)));
+
+ CASE(bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_imm_f32(255.0)),
+ bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_half(va_lut(23), 0)));
+
+ CASE(bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_imm_f32(256.0)),
+ bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_half(va_lut(23), 1)));
+
+ CASE(bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_imm_f32(8.0)),
+ bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_half(va_lut(30), 1)));
+}
+
+TEST_F(LowerConstants, ReplicateFloat16) {
+ CASE(bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_imm_f16(255.0)),
+ bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_half(va_lut(23), 0)));
+
+ CASE(bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_imm_f16(4.0)),
+ bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_half(va_lut(29), 1)));
+}
+
+TEST_F(LowerConstants, NegateFloat32) {
+ CASE(bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_imm_f32(-1.0)),
+ bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_neg(va_lut(16))));
+
+ CASE(bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_imm_f32(-255.0)),
+ bi_fadd_f32_to(b, bi_register(0), bi_register(0), bi_neg(bi_half(va_lut(23), 0))));
+}
+
+TEST_F(LowerConstants, NegateReplicateFloat16)
+{
+ CASE(bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_imm_f16(-255.0)),
+ bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_neg(bi_half(va_lut(23), 0))));
+}
+
+TEST_F(LowerConstants, NegateVec2Float16)
+{
+ CASE(bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_imm_u32(0xBC008000)),
+ bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_neg(va_lut(27))));
+}
+
+TEST_F(LowerConstants, Int8InInt32)
+{
+ CASE(bi_lshift_or_i32(b, bi_register(0), bi_imm_u32(0), bi_imm_u8(6)),
+ bi_lshift_or_i32(b, bi_register(0), va_lut(0), bi_byte(va_lut(9), 2)));
+
+ CASE(bi_lshift_or_i32(b, bi_register(0), bi_imm_u32(0), bi_imm_u8(-2)),
+ bi_lshift_or_i32(b, bi_register(0), va_lut(0), bi_byte(va_lut(3), 0)));
+}
+
+TEST_F(LowerConstants, ZeroExtendForUnsigned)
+{
+ CASE(bi_icmp_u32_to(b, bi_register(0), bi_register(0),
+ bi_imm_u32(0xFF), BI_CMPF_LT, BI_RESULT_TYPE_I1),
+ bi_icmp_u32_to(b, bi_register(0), bi_register(0),
+ bi_byte(va_lut(1), 0), BI_CMPF_LT, BI_RESULT_TYPE_I1));
+
+ CASE(bi_icmp_u32_to(b, bi_register(0), bi_register(0),
+ bi_imm_u32(0xFFFF), BI_CMPF_LT, BI_RESULT_TYPE_I1),
+ bi_icmp_u32_to(b, bi_register(0), bi_register(0),
+ bi_half(va_lut(1), 0), BI_CMPF_LT, BI_RESULT_TYPE_I1));
+}
+
+TEST_F(LowerConstants, SignExtendPositiveForSigned)
+{
+ CASE(bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_imm_u32(0x7F), BI_CMPF_LT, BI_RESULT_TYPE_I1),
+ bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_byte(va_lut(2), 3), BI_CMPF_LT, BI_RESULT_TYPE_I1));
+
+ CASE(bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_imm_u32(0x7FFF), BI_CMPF_LT, BI_RESULT_TYPE_I1),
+ bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_half(va_lut(2), 1), BI_CMPF_LT, BI_RESULT_TYPE_I1));
+}
+
+TEST_F(LowerConstants, SignExtendNegativeForSigned)
+{
+ CASE(bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_imm_u32(0xFFFFFFF8), BI_CMPF_LT, BI_RESULT_TYPE_I1),
+ bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_byte(va_lut(23), 0), BI_CMPF_LT, BI_RESULT_TYPE_I1));
+
+ CASE(bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_imm_u32(0xFFFFFAFC), BI_CMPF_LT, BI_RESULT_TYPE_I1),
+ bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_half(va_lut(3), 1), BI_CMPF_LT, BI_RESULT_TYPE_I1));
+}
+
+TEST_F(LowerConstants, DontZeroExtendForSigned)
+{
+ CASE(bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_imm_u32(0xFF), BI_CMPF_LT, BI_RESULT_TYPE_I1),
+ bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_iadd_imm_i32(b, va_lut(0), 0xFF), BI_CMPF_LT, BI_RESULT_TYPE_I1));
+
+ CASE(bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_imm_u32(0xFFFF), BI_CMPF_LT, BI_RESULT_TYPE_I1),
+ bi_icmp_s32_to(b, bi_register(0), bi_register(0),
+ bi_iadd_imm_i32(b, va_lut(0), 0xFFFF),
+ BI_CMPF_LT, BI_RESULT_TYPE_I1));
+}
+
+TEST_F(LowerConstants, DontZeroExtendNegative)
+{
+ CASE(bi_icmp_u32_to(b, bi_register(0), bi_register(0),
+ bi_imm_u32(0xFFFFFFF8), BI_CMPF_LT, BI_RESULT_TYPE_I1),
+ bi_icmp_u32_to(b, bi_register(0), bi_register(0),
+ bi_iadd_imm_i32(b, va_lut(0), 0xFFFFFFF8),
+ BI_CMPF_LT, BI_RESULT_TYPE_I1));
+
+ CASE(bi_icmp_u32_to(b, bi_register(0), bi_register(0),
+ bi_imm_u32(0xFFFFFAFC), BI_CMPF_LT, BI_RESULT_TYPE_I1),
+ bi_icmp_u32_to(b, bi_register(0), bi_register(0),
+ bi_iadd_imm_i32(b, va_lut(0), 0xFFFFFAFC),
+ BI_CMPF_LT, BI_RESULT_TYPE_I1));
+}
+
+TEST_F(LowerConstants, HandleTrickyNegativesFP16)
+{
+ CASE(bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_imm_f16(-57216.0)),
+ bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_half(va_lut(3), 1)));
+
+ CASE(bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_imm_f16(57216.0)),
+ bi_fadd_v2f16_to(b, bi_register(0), bi_register(0), bi_neg(bi_half(va_lut(3), 1))));
+}
More information about the mesa-commit
mailing list