Mesa (main): mesa/program: fix nir output reg overflow
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Jun 6 19:05:07 UTC 2022
Module: Mesa
Branch: main
Commit: feea8fed44331bc19f6e8869a7c0d421b50b9054
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=feea8fed44331bc19f6e8869a7c0d421b50b9054
Author: Qiang Yu <yuq825 at gmail.com>
Date: Thu Mar 24 11:15:58 2022 +0800
mesa/program: fix nir output reg overflow
outputs_written is uint64_t, should count max reg number
by util_last_bit64(). Otherwise the following access will
overflow the allocated array with a smaller size.
cc: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Signed-off-by: Qiang Yu <yuq825 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15765>
---
src/mesa/program/prog_to_nir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c
index cf5c5b1be2e..5cd073d565e 100644
--- a/src/mesa/program/prog_to_nir.c
+++ b/src/mesa/program/prog_to_nir.c
@@ -916,7 +916,7 @@ setup_registers_and_variables(struct ptn_compile *c)
}
/* Create output registers and variables. */
- int max_outputs = util_last_bit(c->prog->info.outputs_written);
+ int max_outputs = util_last_bit64(c->prog->info.outputs_written);
c->output_regs = rzalloc_array(c, nir_register *, max_outputs);
uint64_t outputs_written = c->prog->info.outputs_written;
More information about the mesa-commit
mailing list