Mesa (main): glsl: Remove stale lower_instructions comments.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jun 7 03:04:35 UTC 2022


Module: Mesa
Branch: main
Commit: d024eb6fabecab0e270af2c30d0c2eb192ad5312
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d024eb6fabecab0e270af2c30d0c2eb192ad5312

Author: Emma Anholt <emma at anholt.net>
Date:   Tue May 31 13:33:14 2022 -0700

glsl: Remove stale lower_instructions comments.

Should have been in 3a42e92a4f2f ("glsl: Drop the dead MOD_TO_FLOOR path.")

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16823>

---

 src/compiler/glsl/lower_instructions.cpp | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/compiler/glsl/lower_instructions.cpp b/src/compiler/glsl/lower_instructions.cpp
index 4c935431a96..46f60b92e70 100644
--- a/src/compiler/glsl/lower_instructions.cpp
+++ b/src/compiler/glsl/lower_instructions.cpp
@@ -72,13 +72,6 @@
  * do have base 2 versions, so this pass converts exp and log to exp2
  * and log2 operations.
  *
- * Many GPUs don't have a MOD instruction (945 and 965 included), and
- * if we have to break it down like this anyway, it gives an
- * opportunity to do things like constant fold the (1.0 / op1) easily.
- *
- * Note: before we used to implement this as op1 * fract(op / op1) but this
- * implementation had significant precision errors.
- *
  * LDEXP_TO_ARITH:
  * -------------
  * Converts ir_binop_ldexp to arithmetic and bit operations for float sources.



More information about the mesa-commit mailing list