Mesa (staging/22.1): 28 new commits

Tue Jun 7 20:19:39 UTC 2022

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=30a9514258af95a0fa904717170b6412de29b2a5
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Thu May 19 12:08:46 2022 -0400

    pan/mdg: Remove uppercase write masks

    These do not convey any additional information, and fail to account for
    shrinking. In particular, a 64-bit writemask with .keephi would fail to
    disassemble and instead trip the assertion, since that would be the ZW
    components. Just delete the broken code.

    Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
    Cc: mesa-stable
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16798>
    (cherry picked from commit 8c11f4809b8c766902ad5ac36d2dd5c0536ce682)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=01eba9dcb2d5968924ddf9cae51521e53f01d845
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Thu May 19 12:29:01 2022 -0400

    pan/mdg: Scalarize with 64-bit sources

    Otherwise, we can get vec3 with u2u32 with 64-bit sources which we need lowered.
    Since our current approach is "scalarize all 64-bit ops", we need to check for
    conversions too.

    Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
    Cc: mesa-stable
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16798>
    (cherry picked from commit 9e4b45795866547a5debecd122d6e72af6a9c603)

    Conflicts:
    	src/panfrost/ci/panfrost-t860-fails.txt

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4da856eaacc32b5cfa5f7f233e8e34f9302be622
Author: Emma Anholt <emma at anholt.net>
Date:   Tue May 31 13:18:09 2022 -0700

    nouveau/nv30: Make sure fsat is lowered in the VS.

    GLSL lowers fsat to clamps based on PIPE_CAP_VERTEX_SHADER_SATURATE
    (EmitNoSat), but nir is happy to optimize that back to fsat unless you
    tell it not to.

    Noticed by inspection while looking at deleting EmitNoSat.

    Fixes: ca1ec7272685 ("nv30/40: Switch to using NIR-to-TGSI by default.")
    Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
    Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16823>
    (cherry picked from commit 7a8e3c80fd41fea5fc3730c79580682d4c92ee15)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7026ff1857132359388c855ffcb3a612b42ef4b4
Author: Nagappa Koppad, Basanagouda <basanagouda.nagappa.koppad at intel.com>
Date:   Mon Jun 6 14:40:06 2022 +0530

    iris:Duplicate DRM fd internally instead of reuse.

    Scenario we want to avoid is double close of DRM fd in iris driver.

    Signed-off-by: Nagappa Koppad, Basanagouda <basanagouda.nagappa.koppad at intel.com>
    Cc: mesa-stable
    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6620
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16886>
    (cherry picked from commit a99e85db9ebd83c41d3606568db8e8d81ca0205c)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8c6c80b0a0b18d41e837bee783364b73964a1e93
Author: Qiang Yu <yuq825 at gmail.com>
Date:   Thu Mar 24 11:15:58 2022 +0800

    mesa/program: fix nir output reg overflow

    outputs_written is uint64_t, should count max reg number
    by util_last_bit64(). Otherwise the following access will
    overflow the allocated array with a smaller size.

    cc: mesa-stable

    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
    Signed-off-by: Qiang Yu <yuq825 at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15765>
    (cherry picked from commit feea8fed44331bc19f6e8869a7c0d421b50b9054)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0b37f7dabc1a76d792d62366798296757427bf94
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date:   Mon May 30 12:46:20 2022 +0100

    aco: fix SMEM load_global with VGPR address and non-zero offset

    Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
    Reviewed-by: Timur Kristóf <timur.kristof at gmail.com>
    Fixes: 3e9517c7577 ("aco: implement _amd global access intrinsics")
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16775>
    (cherry picked from commit f4c02d9116dd01629fbac850d51ba590a1af062a)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b223bf759dc54c71338e9ea8ace6431a5727fd4f
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date:   Mon May 30 12:45:10 2022 +0100

    aco: fix SMEM load_global_amd with non-zero offset

    Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
    Reviewed-by: Timur Kristóf <timur.kristof at gmail.com>
    Fixes: 3e9517c7577 ("aco: implement _amd global access intrinsics")
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16775>
    (cherry picked from commit 4d9f3fcf9cab04c787211b15e645bd28e34a0227)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=379aab1a64da6f502175f7c1373febce91322dd1
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Thu Jun 2 17:06:20 2022 +0200

    v3d: save only required states in blitter

    Some blitter operations, like clear, doesn't require to save all the
    states.

    This is particular important because, besides saving time, the blitter
    operation restores the state required for the operation, and if we saved
    more states than those, these ones won't be restored and will be leak.

    So this also fixes some leaks when running CTS tests.

    CC: mesa-stable
    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
    Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16837>
    (cherry picked from commit 695f66cecd431eb3b8e38f7d3436ff9e44028384)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e01d543c76acf6b0496dc9dde93cc05383344646
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Fri Jun 3 16:32:39 2022 -0400

    format_utils: properly parenthesize macro params

    this otherwise breaks evaluation of the parameters on arm64

    cc: mesa-stable

    fixes #6496

    Reviewed-by: Rob Clark <robdclark at chromium.org>
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16860>
    (cherry picked from commit ba09a00a5cbbcd75b59ec121985ff4d12f220eb8)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c2f4b1acfbfe816735963b10d6757037db8e9a25
Author: Georg Lehmann <dadschoorse at gmail.com>
Date:   Fri Jun 3 16:26:11 2022 +0200

    zink: Use VK_USE_64_BIT_PTR_DEFINES to check for 64bit platforms.

    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6605

    Cc: mesa-stable

    Signed-off-by: Georg Lehmann <dadschoorse at gmail.com>
    Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16853>
    (cherry picked from commit f3c3b8cf2aea12245f87e70d9f007e6260d3a6db)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e0f34e6bafbd7c7d9682a0c5f215b62a6922064e
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Wed Jun 1 14:12:16 2022 -0400

    zink: fix dmabuf plane layout struct scoping

    this struct needs to exist for all the scopes it's used in

    cc: mesa-stable

    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16822>
    (cherry picked from commit c57fa8b390414f93ca24b027c708c5f854eafcf2)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=39ca39d4f3f2df71422e0fbf9fe28145e437dc93
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Wed Jun 1 11:31:49 2022 -0400

    kopper: use get_drawable_info path for non-x11 drawables

    wayland surfaces need to take this path to get resizing right

    cc: mesa-stable

    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16814>
    (cherry picked from commit b6a80142178ddba9d5b970b53e1f621b95235755)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b3b4b2d5636d735642903f43fa05e1c3206d3179
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Wed Jun 1 16:34:32 2022 -0400

    egl/wayland: skip buffer creation on zink

    this happens through wsi, so don't create resources that aren't used

    cc: mesa-stable

    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16814>
    (cherry picked from commit 20ba7596949085bcf06ba48ff4f1a0784c6a6e24)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=575da2866f53d334692cfe452bc62b2d1210e2d3
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Wed Jun 1 10:47:27 2022 -0400

    egl/wayland: manually swap backbuffer when using zink

    this would usually occur through dri2_wl_swrast_commit_backbuffer(),
    but zink triggers this functionality using vulkan wsi, which fails to
    perform these updates as expected

    cc: mesa-stable

    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16814>
    (cherry picked from commit f67bd8adfab7eac1bd83ee5d3cc90d6dce76fbf3)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e58cd4a6f91adb34400e6d86b05506658f721e20
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date:   Thu May 19 10:57:40 2022 +0200

    st/mesa: use mutex in st_get_texture_sampler_view_from_stobj

    st_texture_release_all_sampler_views uses the validate_mutex,
    but st_get_texture_sampler_view_from_stobj didn't.

    Since they both modify stObj->view we could have threadA in
    st_get_texture_sampler_view_from_stobj with a non-NULL sv,
    so expecting sv->view to be non-NULL, while threadB was in
    st_texture_release_all_sampler_views clearing sv->view.

    It's also needed to protect st_sampler_view::private_refcount,
    which is supposed to be used from the owning context thread,
    but can also be used by any context in st_texture_release_all_sampler_views.

    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6088
    Fixes: ef5d4274132 ("st/mesa: add a mechanism to bypass atomics when binding sampler views")
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16779>
    (cherry picked from commit b51e40ebdecea4bfe0afa8200d068fc35798596f)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e6ad3c0fd770546520d84c0626d0857dd4aa0bfa
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Wed May 25 10:18:32 2022 +0200

    microsoft/spirv_to_dxil: Fix the push_constant UBO size calculation

    Right now, we just consider the size of the accessed portion of the
    push constant array, but it doesn't necessarily reflect the size
    of the UBO we should declare.

    Fixes: de1e941c5909 ("microsoft/spirv_to_dxil: Lower push constant loads to UBO loads")
    Reviewed-by: Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16703>
    (cherry picked from commit 2feef505c1e93f23bfd480eced4e1f7c7755c5ad)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=211d980d297f818f4d059ad5ca24ec397ee17399
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Wed May 25 10:05:26 2022 +0200

    microsoft/spirv_to_dxil: Fix push_constants type declaration

    We're not declaring an array of bytes but an array of uint32. Let's
    fix the element_count we pass to glsl_array_type().

    Fixes: de1e941c5909 ("microsoft/spirv_to_dxil: Lower push constant loads to UBO loads")
    Reviewed-by: Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16703>
    (cherry picked from commit 6783a8845566a9fdffa938d5b99127f7a3af0edf)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=551396ed7b711696143c40f9867b6d222cbf4f12
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Thu Jun 2 09:03:16 2022 +0200

    radv: enable radv_zero_vram for Hammerting

    This native Vulkan game is broken, it has TON of Vulkan validation
    errors and hangs without RADV_DEBUG=zerovram. Also tested with PRO
    and AMDVLK.

    The application name is also not really descriptive but the executable
    name 'boot.exe' is worst.

    https://github.com/ValveSoftware/Proton/issues/4347#issuecomment-1141415515

    Cc: mesa-stable
    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16832>
    (cherry picked from commit fe9f1d064af05464e5a31c74ea0d063b8c20611d)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dc7c2df02b87966ddd67851085e629e0f982eb1a
Author: Dave Airlie <airlied at redhat.com>
Date:   Fri Jun 3 12:25:32 2022 +1000

    llvmpipe: handle timespec overflow on fence waits.

    on 32-bit systems VK CTS was failing due to an overflow here,
    detect the overflow and just do a normal wait.

    Fixes: 5b284fe6bc0a ("llvmpipe: add lp_fence_timedwait() helper")
    Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16847>
    (cherry picked from commit b62dd20dea64c3ab5a79673fcfd9442e4f80b855)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9097462c37ccdda899ce59e53572e8890a47e701
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Thu Jun 2 14:04:04 2022 -0400

    zink: force queries to start/end out of renderpass

    spec requires queries to either start and end in the same renderpass
    or start and end outside of renderpass, so do the latter since it's
    easier to track

    cc: mesa-stable

    fixes #6579

    Reviewed-by: Dave Airlie <airlied at redhat.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16844>
    (cherry picked from commit d9ab27944d800d84296ded8489349d3240f0d2da)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5baf33795a56f7b54fc9ecba17032c69201e4399
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Thu Jun 2 20:27:41 2022 -0400

    pan/bi: Fix clper_xor on Mali-G31

    Mali-G31 has the old CLPER instruction, not the new one, which means we don't
    get to specify a custom lane op. But the clper_xor helper incorrectly checked
    the arch, not the implementation quirk.

    Fixes: c00e7b729fe ("pan/bi: Optimize abs(derivative)")
    Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
    Reported-by: Icecream95 <ixn at disroot.org>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16846>
    (cherry picked from commit 7535362204642db2b59b48ac910cb74146bb96a6)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d962bdcdd344b1b397ceba0f332709dd4abe0f88
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Thu Jun 2 02:11:15 2022 -0700

    intel/compiler: Fix uncompaction of signed word immediates on Tigerlake

    This expression accidentally performs a 32-bit sign-extension when
    processing the second half of the expression (the low 16 bits).

    Consider -7W, which is represented as 0xfff9fff9 in our encoding (the
    16-bit word is replicated to both halves of the 32-bit dword).

    Tigerlake's compaction stores the low 11-bits of an immediate as-is,
    and replicates the 12th bit.  So here, compacted_imm will be 0xff9.

       (  (int)(0xff9 << 20) >> 4) |
       ((short)(0xff9 <<  4) >> 4))

       0xfff90000 | (0xff90 >> 4)
       0xfff90000 | 0xfffffff9 ...oops...
       0xfffffff9

    By casting the second line of the expression to unsigned short, we
    prevent the sign-extension when it combines both parts, so we get:

       0xfff90000 | 0x0000fff9
       0xfff9fff9

    Fixes: 12d3b11908e ("intel/compiler: Add instruction compaction support on Gen12")
    Reviewed-by: Matt Turner <mattst88 at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16833>
    (cherry picked from commit 26bb81f3f62ff5a19f360f4b6d2f72bdcb229360)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=03847428d8844d26a856a459535ad1eb1322ca48
Author: Dylan Baker <dylan.c.baker at intel.com>
Date:   Tue Jun 7 11:01:56 2022 -0700

    .pick_status.json: Update to 49234585772f49626435d3d9324ad144e27fc453

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9b77caa70f2ff3eadbb6847f1752a1f5a901db9b
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Wed Jun 1 16:25:58 2022 -0400

    lavapipe: fix dynamic patchControlPoints

    the dynamic state value is independent of whether tesselation is used

    cc: mesa-stable

    Reviewed-by: Dave Airlie <airlied at redhat.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16824>
    (cherry picked from commit fc5a3e1e37ac1d4f081304c0b3bcd253e5b524fb)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c9d10441f09b22e00d5ea1ca58c7980bae3d7c5a
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date:   Tue May 31 08:54:30 2022 +0200

    intel: remove stale makefile

    When this landed, the Autotools build system was already removed. Why
    was this file added in the first place? Probably a rebase-mistake...

    Fixes: 134e750e16b ("i965: extract performance query metrics")
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16790>
    (cherry picked from commit a8605db504b20607b3e9461e5fbbbd2bdeff155f)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=85d1edec9b463d57b179d4ba0a4f8ba70643d92e
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date:   Tue May 31 07:27:42 2022 +0200

    freedreno: remove stale makefile

    We don't use this makefile, so there's no point in keeping it in the
    repo. It's also a generated one, so it contains a lot of... mess.

    Fixes: 536f43cb96b ("freedreno: slurp in afuc")
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Reviewed-by: Rob Clark <robdclark at chromium.org>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16790>
    (cherry picked from commit 9bcd5386431a5a735a9d179a395af14baca7dc87)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e320dce31a1f1a1763b7a95060d460d3932fa7e4
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Wed Jun 1 14:34:08 2022 -0400

    panfrost: Fix XML for AFBC header on v9

    Misnamed field due to copy/paste fail from Bifrost.

    Fixes: c011ea6c265 ("panfrost: Shuffle render target AFBC for Valhall")
    Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16800>
    (cherry picked from commit 2cc2f217d4e686538ba52f9a9062af5efaa13b49)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ae07db983d042fe696a705b1cbd420768a269682
Author: Dylan Baker <dylan.c.baker at intel.com>
Date:   Thu Jun 2 10:37:22 2022 -0700

    .pick_status.json: Update to ad5c84999b9eb2522cdf78bb0890939450280cf3