Mesa (main): pvr: csbgen: Make some loops more pythonic

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 8 09:22:02 UTC 2022


Module: Mesa
Branch: main
Commit: 34a76ec4e6cf9d9f240f9a03b0887d90a5d116e3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=34a76ec4e6cf9d9f240f9a03b0887d90a5d116e3

Author: Matt Coster <matt.coster at imgtec.com>
Date:   Fri May 13 10:31:37 2022 +0100

pvr: csbgen: Make some loops more pythonic

Signed-off-by: Matt Coster <matt.coster at imgtec.com>
Reviewed-by: Frank Binns <frank.binns at imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16884>

---

 src/imagination/csbgen/gen_pack_header.py | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/imagination/csbgen/gen_pack_header.py b/src/imagination/csbgen/gen_pack_header.py
index 2626d1faeb8..ec41ea1dafc 100644
--- a/src/imagination/csbgen/gen_pack_header.py
+++ b/src/imagination/csbgen/gen_pack_header.py
@@ -755,20 +755,19 @@ class Group(object):
                 print(" |\n".join("      " + f for f in non_address_fields) + ";")
 
             if dw.size == 32:
-                for i in range(address_count):
+                for addr in dw.addresses:
                     print("    dw[%d] = __pvr_address(values->%s, %d, %d, %d) | %s;"
-                          % (index, dw.addresses[i].name + field.dim, dw.addresses[i].shift,
-                             dw.addresses[i].start - dword_start, dw.addresses[i].end - dword_start, v))
+                          % (index, addr.name + field.dim, addr.shift, addr.start - dword_start,
+                             addr.end - dword_start, v))
                 continue
 
             v_accumulated_addr = ""
-            for i in range(address_count):
+            for i, addr in enumerate(dw.addresses):
                 v_address = "v%d_address" % i
                 v_accumulated_addr += "v%d_address" % i
                 print("    const uint64_t %s =" % v_address)
                 print("      __pvr_address(values->%s, %d, %d, %d);"
-                      % (dw.addresses[i].name + field.dim, dw.addresses[i].shift,
-                         dw.addresses[i].start - dword_start, dw.addresses[i].end - dword_start))
+                      % (addr.name + field.dim, addr.shift, addr.start - dword_start, addr.end - dword_start))
                 if i < (address_count - 1):
                     v_accumulated_addr += " |\n            "
 



More information about the mesa-commit mailing list