Mesa (main): pvr: csbgen: Fix "local variable may be undefined" lints

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 8 09:22:03 UTC 2022


Module: Mesa
Branch: main
Commit: 4c0941f0d4ee9a558a7a1652f5c1e85e8af1b8d8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4c0941f0d4ee9a558a7a1652f5c1e85e8af1b8d8

Author: Matt Coster <matt.coster at imgtec.com>
Date:   Fri May 13 10:47:33 2022 +0100

pvr: csbgen: Fix "local variable may be undefined" lints

Signed-off-by: Matt Coster <matt.coster at imgtec.com>
Reviewed-by: Frank Binns <frank.binns at imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16884>

---

 src/imagination/csbgen/gen_pack_header.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/imagination/csbgen/gen_pack_header.py b/src/imagination/csbgen/gen_pack_header.py
index 37874ec681c..9a932c45244 100644
--- a/src/imagination/csbgen/gen_pack_header.py
+++ b/src/imagination/csbgen/gen_pack_header.py
@@ -856,9 +856,6 @@ class Parser:
         self.filename = ""
 
     def start_element(self, name: str, attrs: t.Dict[str, str]) -> None:
-        if not name == "csbgen":
-            parent = self.context[-1]
-
         if name == "csbgen":
             if self.context:
                 raise RuntimeError(
@@ -868,8 +865,11 @@ class Parser:
 
             csbgen = Csbgen(attrs["name"], attrs["prefix"], self.filename)
             self.context.append(csbgen)
+            return
 
-        elif name == "struct":
+        parent = self.context[-1]
+
+        if name == "struct":
             struct = Struct(parent, attrs["name"], int(attrs["length"]))
             self.context.append(struct)
 



More information about the mesa-commit mailing list