Mesa (main): panfrost: Remove is_64b assignments

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 8 13:56:10 UTC 2022


Module: Mesa
Branch: main
Commit: 58b408611ffa9f64e6f8b484d6a475bdc711e512
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=58b408611ffa9f64e6f8b484d6a475bdc711e512

Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Tue Jun  7 16:10:43 2022 -0400

panfrost: Remove is_64b assignments

These are redundant with GenXML defaults, they're just noise.

Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16916>

---

 src/gallium/drivers/panfrost/pan_cmdstream.c | 2 --
 src/panfrost/lib/pan_indirect_dispatch.c     | 1 -
 src/panfrost/lib/pan_indirect_draw.c         | 2 --
 src/panfrost/vulkan/panvk_vX_cs.c            | 1 -
 4 files changed, 6 deletions(-)

diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c
index abb36e5325f..e8f6b21aa51 100644
--- a/src/gallium/drivers/panfrost/pan_cmdstream.c
+++ b/src/gallium/drivers/panfrost/pan_cmdstream.c
@@ -2917,7 +2917,6 @@ panfrost_draw_emit_vertex_section(struct panfrost_batch *batch,
                                   void *section)
 {
         pan_pack(section, DRAW, cfg) {
-                cfg.draw_descriptor_is_64b = true;
                 cfg.state = batch->rsd[PIPE_SHADER_VERTEX];
                 cfg.attributes = attribs;
                 cfg.attribute_buffers = attrib_bufs;
@@ -4147,7 +4146,6 @@ panfrost_launch_grid(struct pipe_context *pipe,
         }
 
         pan_section_pack(t.cpu, COMPUTE_JOB, DRAW, cfg) {
-                cfg.draw_descriptor_is_64b = true;
                 cfg.state = batch->rsd[PIPE_SHADER_COMPUTE];
                 cfg.attributes = panfrost_emit_image_attribs(batch, &cfg.attribute_buffers, PIPE_SHADER_COMPUTE);
                 cfg.thread_storage = panfrost_emit_shared_memory(batch, info);
diff --git a/src/panfrost/lib/pan_indirect_dispatch.c b/src/panfrost/lib/pan_indirect_dispatch.c
index 614d1acb31b..f2f78cea8ea 100644
--- a/src/panfrost/lib/pan_indirect_dispatch.c
+++ b/src/panfrost/lib/pan_indirect_dispatch.c
@@ -73,7 +73,6 @@ GENX(pan_indirect_dispatch_emit)(struct pan_pool *pool,
         }
 
         pan_section_pack(job.cpu, COMPUTE_JOB, DRAW, cfg) {
-                cfg.draw_descriptor_is_64b = true;
                 cfg.state = get_rsd(dev);
                 cfg.thread_storage = get_tls(pool->dev);
                 cfg.push_uniforms =
diff --git a/src/panfrost/lib/pan_indirect_draw.c b/src/panfrost/lib/pan_indirect_draw.c
index befdf3a2041..3fa1f5485eb 100644
--- a/src/panfrost/lib/pan_indirect_draw.c
+++ b/src/panfrost/lib/pan_indirect_draw.c
@@ -1251,7 +1251,6 @@ panfrost_emit_index_min_max_search(struct pan_pool *pool,
         }
 
         pan_section_pack(job.cpu, COMPUTE_JOB, DRAW, cfg) {
-                cfg.draw_descriptor_is_64b = true;
                 cfg.state = rsd;
                 cfg.thread_storage = get_tls(pool->dev);
                 cfg.push_uniforms =
@@ -1334,7 +1333,6 @@ GENX(panfrost_emit_indirect_draw)(struct pan_pool *pool,
         }
 
         pan_section_pack(job.cpu, COMPUTE_JOB, DRAW, cfg) {
-                cfg.draw_descriptor_is_64b = true;
                 cfg.state = rsd;
                 cfg.thread_storage = get_tls(pool->dev);
                 cfg.push_uniforms =
diff --git a/src/panfrost/vulkan/panvk_vX_cs.c b/src/panfrost/vulkan/panvk_vX_cs.c
index f3034439607..453661da93a 100644
--- a/src/panfrost/vulkan/panvk_vX_cs.c
+++ b/src/panfrost/vulkan/panvk_vX_cs.c
@@ -452,7 +452,6 @@ panvk_per_arch(emit_vertex_job)(const struct panvk_pipeline *pipeline,
    }
 
    pan_section_pack(job, COMPUTE_JOB, DRAW, cfg) {
-      cfg.draw_descriptor_is_64b = true;
       cfg.state = pipeline->rsds[MESA_SHADER_VERTEX];
       cfg.attributes = draw->stages[MESA_SHADER_VERTEX].attributes;
       cfg.attribute_buffers = draw->stages[MESA_SHADER_VERTEX].attribute_bufs;



More information about the mesa-commit mailing list