Mesa (main): microsoft/spirv_to_dxil: Let spirv_to_dxil() handle the linking

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 8 15:57:27 UTC 2022


Module: Mesa
Branch: main
Commit: 74c94faf325dcae85f7f41d40d5988cf5412767a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=74c94faf325dcae85f7f41d40d5988cf5412767a

Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Fri Apr 29 08:15:17 2022 -0700

microsoft/spirv_to_dxil: Let spirv_to_dxil() handle the linking

That's still a dummy linking we do here, and it's likely to be
incorrect for complex scenarios. Not sure the previous situation
was any better though, and at least, doing that allows us to
get rid of the special cases we have in dxil_signature.c.

Reviewed-by: Enrico Galli <enrico.galli at intel.com>
Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16221>

---

 src/microsoft/spirv_to_dxil/spirv_to_dxil.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/microsoft/spirv_to_dxil/spirv_to_dxil.c b/src/microsoft/spirv_to_dxil/spirv_to_dxil.c
index 4564e67726f..60d357c5c0e 100644
--- a/src/microsoft/spirv_to_dxil/spirv_to_dxil.c
+++ b/src/microsoft/spirv_to_dxil/spirv_to_dxil.c
@@ -136,7 +136,6 @@ spirv_to_dxil(const uint32_t *words, size_t word_count,
 
    struct nir_to_dxil_options opts = {
       .environment = DXIL_ENVIRONMENT_VULKAN,
-      .auto_link = true,
    };
    struct blob dxil_blob;
    if (!nir_to_dxil(nir, &opts, &dxil_blob)) {



More information about the mesa-commit mailing list