Mesa (main): zink: avoid uninit values in renderpass state
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Jun 14 19:34:38 UTC 2022
Module: Mesa
Branch: main
Commit: d8877437d6125c63b4bfe0b048981770f25a9d16
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d8877437d6125c63b4bfe0b048981770f25a9d16
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Mon Jun 13 15:05:09 2022 -0400
zink: avoid uninit values in renderpass state
cc: mesa-stable
Reviewed-by: Adam Jackson <ajax at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17010>
---
src/gallium/drivers/zink/zink_render_pass.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/zink/zink_render_pass.c b/src/gallium/drivers/zink/zink_render_pass.c
index 4b15bbca7c1..dfa807b582b 100644
--- a/src/gallium/drivers/zink/zink_render_pass.c
+++ b/src/gallium/drivers/zink/zink_render_pass.c
@@ -50,6 +50,7 @@ create_render_pass2(struct zink_screen *screen, struct zink_render_pass_state *s
pstate->num_attachments = state->num_cbufs;
pstate->num_cresolves = state->num_cresolves;
pstate->num_zsresolves = state->num_zsresolves;
+ pstate->fbfetch = 0;
for (int i = 0; i < state->num_cbufs; i++) {
struct zink_rt_attrib *rt = state->rts + i;
attachments[i].sType = VK_STRUCTURE_TYPE_ATTACHMENT_DESCRIPTION_2;
@@ -155,12 +156,9 @@ create_render_pass2(struct zink_screen *screen, struct zink_render_pass_state *s
}
pstate->num_attachments++;
}
- if (dep_access & VK_ACCESS_COLOR_ATTACHMENT_READ_BIT)
- pstate->color_read = true;
- if (dep_access & VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT)
- pstate->depth_read = true;
- if (dep_access & VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT)
- pstate->depth_write = true;
+ pstate->color_read = (dep_access & VK_ACCESS_COLOR_ATTACHMENT_READ_BIT) > 0;
+ pstate->depth_read = (dep_access & VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT) > 0;
+ pstate->depth_write = (dep_access & VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT) > 0;
if (!screen->info.have_KHR_synchronization2)
dep_pipeline = MAX2(dep_pipeline, VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT);
More information about the mesa-commit
mailing list