Mesa (staging/22.1): zink: don't print VK_EXT_shader_atomic_float warning for nir_intrinsic_image_deref_atomic_exchange
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Jun 15 16:22:56 UTC 2022
Module: Mesa
Branch: staging/22.1
Commit: d66ed8bd654d32bac2f7f072d97647df6e3fa75b
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d66ed8bd654d32bac2f7f072d97647df6e3fa75b
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Tue Jun 14 10:22:08 2022 -0400
zink: don't print VK_EXT_shader_atomic_float warning for nir_intrinsic_image_deref_atomic_exchange
this is covered by base spec and doesn't require the extension
cc: mesa-stable
Reviewed-by: Adam Jackson <ajax at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17010>
(cherry picked from commit 03d7f31054b16b17eaafe1714c4648151861c014)
---
.pick_status.json | 2 +-
src/gallium/drivers/zink/zink_compiler.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/.pick_status.json b/.pick_status.json
index ab5e8a6213f..20bbce5af14 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -1156,7 +1156,7 @@
"description": "zink: don't print VK_EXT_shader_atomic_float warning for nir_intrinsic_image_deref_atomic_exchange",
"nominated": true,
"nomination_type": 0,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": null
},
diff --git a/src/gallium/drivers/zink/zink_compiler.c b/src/gallium/drivers/zink/zink_compiler.c
index e004825ef18..af5a7d14151 100644
--- a/src/gallium/drivers/zink/zink_compiler.c
+++ b/src/gallium/drivers/zink/zink_compiler.c
@@ -1965,8 +1965,7 @@ scan_nir(struct zink_screen *screen, nir_shader *shader, struct zink_shader *zs)
static bool warned = false;
if (!screen->info.have_EXT_shader_atomic_float && !screen->is_cpu && !warned) {
switch (intr->intrinsic) {
- case nir_intrinsic_image_deref_atomic_add:
- case nir_intrinsic_image_deref_atomic_exchange: {
+ case nir_intrinsic_image_deref_atomic_add: {
nir_variable *var = nir_intrinsic_get_var(intr, 0);
if (util_format_is_float(var->data.image.format))
fprintf(stderr, "zink: Vulkan driver missing VK_EXT_shader_atomic_float but attempting to do atomic ops!\n");
More information about the mesa-commit
mailing list