Mesa (main): venus: fix a bug on buffer cache init failure path

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jun 16 19:06:12 UTC 2022


Module: Mesa
Branch: main
Commit: 01a0bfc3f994834318814328978eff05d27ac5a8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=01a0bfc3f994834318814328978eff05d27ac5a8

Author: Yiwei Zhang <zzyiwei at chromium.org>
Date:   Sat May 21 22:28:54 2022 +0000

venus: fix a bug on buffer cache init failure path

The failure path was never hit though, and will not either.

Fixes: 65abd1d4aed ("venus: implement vn_buffer_cache_entries_create")

Signed-off-by: Yiwei Zhang <zzyiwei at chromium.org>
Reviewed-by: Chad Versace <chadversary at chromium.org>
Reviewed-by: Ryan Neph <ryanneph at google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16731>

---

 src/virtio/vulkan/vn_buffer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/virtio/vulkan/vn_buffer.c b/src/virtio/vulkan/vn_buffer.c
index cd075d80bdd..fa370e079ce 100644
--- a/src/virtio/vulkan/vn_buffer.c
+++ b/src/virtio/vulkan/vn_buffer.c
@@ -124,8 +124,8 @@ vn_buffer_cache_entries_create(struct vn_device *dev,
       if (buf->requirements.memory.memoryRequirements.alignment <
           buf->requirements.memory.memoryRequirements.size) {
          vk_free(alloc, entries);
-         *out_entries = entries;
-         *out_entry_count = entry_count;
+         *out_entries = NULL;
+         *out_entry_count = 0;
          return VK_SUCCESS;
       }
 



More information about the mesa-commit mailing list