Mesa (main): radv: Remove redundant memset in radv_descriptor_set_create.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Jun 20 11:14:47 UTC 2022


Module: Mesa
Branch: main
Commit: ceb3ae2afb888579c761741b93ca1fa5a2e41bba
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ceb3ae2afb888579c761741b93ca1fa5a2e41bba

Author: Georg Lehmann <dadschoorse at gmail.com>
Date:   Sun Jun 19 22:12:54 2022 +0200

radv: Remove redundant memset in radv_descriptor_set_create.

The memset below also clears this memory, plus the descriptor set header.

Signed-off-by: Georg Lehmann <dadschoorse at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Konstantin Seurer <konstantin.seurer at gmail.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17127>

---

 src/amd/vulkan/radv_descriptor_set.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c
index 92b8dba3a79..ba3dc3d9b2a 100644
--- a/src/amd/vulkan/radv_descriptor_set.c
+++ b/src/amd/vulkan/radv_descriptor_set.c
@@ -648,7 +648,6 @@ radv_descriptor_set_create(struct radv_device *device, struct radv_descriptor_po
 
       set = (struct radv_descriptor_set *)pool->host_memory_ptr;
       pool->host_memory_ptr += mem_size;
-      memset(set->descriptors, 0, sizeof(struct radeon_winsys_bo *) * buffer_count);
    } else {
       set = vk_alloc2(&device->vk.alloc, NULL, mem_size, 8, VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 



More information about the mesa-commit mailing list