Mesa (main): virgl: overpropagate precise flags

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 22 13:26:04 UTC 2022


Module: Mesa
Branch: main
Commit: 42a126495113ff7f18be759e4606435d54b48fcc
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=42a126495113ff7f18be759e4606435d54b48fcc

Author: Italo Nicola <italonicola at collabora.com>
Date:   Mon Jun 20 14:45:43 2022 -0300

virgl: overpropagate precise flags

As it turns out, MOVs weren't the only instructions that blocked precise
flags propagation in the transition to nir-to-tgsi.
This commit fixes some rendering regressions caused by a4a34cd3.

Fixes: a4a34cd3

Signed-off-by: Italo Nicola <italonicola at collabora.com>
Reviewed-by: Gert Wollny <gert.wollny at collanora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17144>

---

 src/gallium/drivers/virgl/virgl_tgsi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/gallium/drivers/virgl/virgl_tgsi.c b/src/gallium/drivers/virgl/virgl_tgsi.c
index d16b3a6dac1..a98a74ea2eb 100644
--- a/src/gallium/drivers/virgl/virgl_tgsi.c
+++ b/src/gallium/drivers/virgl/virgl_tgsi.c
@@ -288,8 +288,6 @@ virgl_tgsi_transform_instruction(struct tgsi_transform_context *ctx,
           * one precise output */
          if (inst->Instruction.Precise)
             vtctx->precise_flags[index] |= bits;
-         else if (inst->Instruction.Opcode != TGSI_OPCODE_MOV)
-            vtctx->precise_flags[index] &= ~bits;
       } else if (inst->Instruction.Opcode == TGSI_OPCODE_MOV) {
          for (int i = 0; i < inst->Instruction.NumSrcRegs; ++i) {
             if (inst->Src[i].Register.File == TGSI_FILE_TEMPORARY) {



More information about the mesa-commit mailing list