Mesa (staging/22.1): pan/bi: Fix LD_BUFFER.i16 definition

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jun 23 16:19:36 UTC 2022


Module: Mesa
Branch: staging/22.1
Commit: b5d711a9b25118e227c09901376f10d28fb056d5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b5d711a9b25118e227c09901376f10d28fb056d5

Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Thu Jun 16 19:04:13 2022 -0400

pan/bi: Fix LD_BUFFER.i16 definition

This was missing the message, breaking UBO-to-push and who-knows-what-else, when
enabling fp16 const buffers.

Fixes: 3dc2095b079 ("pan/bi: Model LD_BUFFER instructions")
Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17101>
(cherry picked from commit 5ee1179c946a2710e6621192fe8f0cfbf49d368d)

---

 .pick_status.json            | 2 +-
 src/panfrost/bifrost/ISA.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.pick_status.json b/.pick_status.json
index c858c93cb3b..5674fbc10e6 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -859,7 +859,7 @@
         "description": "pan/bi: Fix LD_BUFFER.i16 definition",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": "3dc2095b079f1ac890cbf6ca2f525841a2dab5ba"
     },
diff --git a/src/panfrost/bifrost/ISA.xml b/src/panfrost/bifrost/ISA.xml
index 5970f7da675..700f8307839 100644
--- a/src/panfrost/bifrost/ISA.xml
+++ b/src/panfrost/bifrost/ISA.xml
@@ -8698,7 +8698,7 @@
     <src start="3"/>
   </ins>
 
-  <ins name="+LD_BUFFER.i16" staging="w=1" pseudo="true">
+  <ins name="+LD_BUFFER.i16" staging="w=1" pseudo="true" message="load">
     <src start="0"/>
     <src start="3"/>
     <mod name="lane_dest" size="2" default="h0">



More information about the mesa-commit mailing list