Mesa (main): lavapipe: skip post-copy pNext checking during pipeline creation for composites
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Jun 24 00:28:19 UTC 2022
Module: Mesa
Branch: main
Commit: b74d3e71be4f48c673516b2d70ea9eb914049e6a
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b74d3e71be4f48c673516b2d70ea9eb914049e6a
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Thu Jun 23 10:28:16 2022 -0400
lavapipe: skip post-copy pNext checking during pipeline creation for composites
these values should have all been set during pipeline compositing above,
so reapplying the values is at best, redundant, and at worst, broken
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17219>
---
src/gallium/frontends/lavapipe/lvp_pipeline.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/gallium/frontends/lavapipe/lvp_pipeline.c b/src/gallium/frontends/lavapipe/lvp_pipeline.c
index dda92404789..0e295f220b1 100644
--- a/src/gallium/frontends/lavapipe/lvp_pipeline.c
+++ b/src/gallium/frontends/lavapipe/lvp_pipeline.c
@@ -1443,9 +1443,8 @@ lvp_graphics_pipeline_init(struct lvp_pipeline *pipeline,
}
}
}
- }
-
- if (pipeline->stages & VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT) {
+ } else if (pipeline->stages & VK_GRAPHICS_PIPELINE_LIBRARY_PRE_RASTERIZATION_SHADERS_BIT_EXT) {
+ /* composite pipelines should have these values set above */
if (pipeline->graphics_create_info.pViewportState) {
/* if pViewportState is null, it means rasterization is discarded,
* so this is ignored
More information about the mesa-commit
mailing list