Mesa (main): radv: dump UMR waves before UMR rings

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Jun 27 08:59:59 UTC 2022


Module: Mesa
Branch: main
Commit: fd997bde2f94a4d1510ea0543779eadeaa7a4aba
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fd997bde2f94a4d1510ea0543779eadeaa7a4aba

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Jun 22 10:34:34 2022 +0200

radv: dump UMR waves before UMR rings

Dumping UMR rings might be slow and dumping waves before would make it
more chance to dump them without reporting "No active waves".

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17183>

---

 src/amd/vulkan/radv_debug.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/amd/vulkan/radv_debug.c b/src/amd/vulkan/radv_debug.c
index 138dad6f94d..67b46375b79 100644
--- a/src/amd/vulkan/radv_debug.c
+++ b/src/amd/vulkan/radv_debug.c
@@ -739,19 +739,19 @@ radv_check_gpu_hangs(struct radv_queue *queue, struct radeon_cmdbuf *cs)
    }
 
    if (!(device->instance->debug_flags & RADV_DEBUG_NO_UMR)) {
-      /* Dump UMR ring. */
-      snprintf(dump_path, sizeof(dump_path), "%s/%s", dump_dir, "umr_ring.log");
+      /* Dump UMR waves. */
+      snprintf(dump_path, sizeof(dump_path), "%s/%s", dump_dir, "umr_waves.log");
       f = fopen(dump_path, "w+");
       if (f) {
-         radv_dump_umr_ring(queue, f);
+         radv_dump_umr_waves(queue, f);
          fclose(f);
       }
 
-      /* Dump UMR waves. */
-      snprintf(dump_path, sizeof(dump_path), "%s/%s", dump_dir, "umr_waves.log");
+      /* Dump UMR ring. */
+      snprintf(dump_path, sizeof(dump_path), "%s/%s", dump_dir, "umr_ring.log");
       f = fopen(dump_path, "w+");
       if (f) {
-         radv_dump_umr_waves(queue, f);
+         radv_dump_umr_ring(queue, f);
          fclose(f);
       }
    }



More information about the mesa-commit mailing list