Mesa (main): 23 new commits

Tue Jun 28 13:17:10 UTC 2022

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3129520a73336d72284cd98412bb8d77ed8415de
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Wed Jun 22 11:01:19 2022 +0200

    ci/dzn: Add pipeline cache tests to the include list
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=91f1bd8f81dff866c769ea3bcc58450b9293b1a4
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Wed Jun 22 10:43:04 2022 +0200

    dzn: Cache pipeline info
    
    We are already caching DXIL shaders individually, but that forces us
    to retrieve the NIR shader, do the linking and binding translation
    steps, to finally query the cache for each DXIL shader. This pipeline
    caching is about skipping those steps when we can.
    
    Note that a graphics/compute pipeline cache entry doesn't contain the
    DXIL shaders, but hashes to retrieve those shaders from the same cache.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d8b686783ef9605195c8d85df7f6fa6176e8602b
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Wed Jun 22 10:32:41 2022 +0200

    dzn: Cache DXIL shaders
    
    This way we avoid the NIR -> DXIL translation when we have a cache hit.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=52e2ca084af74ec3d00fa1e4d9546093289071a0
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Wed Jun 22 09:46:49 2022 +0200

    dzn: Caculate a binding translation hash
    
    Binding translation has an impact on the final DXIL shader, and this
    binding translation depends on the pipeline layout. Let's extend the
    adjust_var_bindings() pass to caculate a hash we can then use in the
    DXIL shader hash caculation.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=276c73580d20e277e17a0fbac061bc4aca3152b5
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Wed Jun 22 09:12:51 2022 +0200

    dzn: Cache NIR shaders
    
    Saves us the SPIRV -> NIR translation, and all the lowering passes run
    in dxil_spirv_nir_passes().
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=66764904b3a4c17f5c904c3986fccd5b9265a5d3
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Wed Jun 22 09:19:04 2022 +0200

    dzn: Move the compute shader compilation logic to a sub-function
    
    Will make things easier when we introduce shader caching.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6236d1eead45825de9c21d9ec3a5af2e13e1b56c
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Wed Jun 22 09:33:12 2022 +0200

    dzn: Drop unneeded goto statement in dzn_compute_pipeline_create()
    
    The 'out' label is placed just after the if () block, we can thus
    remove the 'goto out;' statement.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d4630b703d23821ac57e52e9b9b58307029aa404
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Tue Jun 21 17:12:17 2022 +0200

    dzn: Add a generic cached blob wrapper
    
    Basically what vk_pipeline_cache's raw_data_object abstraction provides,
    but I'm not sure it makes sense to make it generic so I copied it here.
    Might be more appropriate to make raw_data_object public.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=06f37025f14a3f4b3a4effb45c22cb343ed32e2a
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Tue Jun 21 17:09:27 2022 +0200

    dzn: Hash pipeline layout stages
    
    DXIL shaders depend on the vulkan -> d3d12 binding translation done in
    adjust_var_bindings(). In order to maximize our chances to re-use those
    shaders, we need to hash the binding translation information and take
    this hash into account when computing the DXIL shader hash.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=391d3251fa2e17dc7dd8eef3069337e71b9cf1af
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Tue Jun 21 02:53:05 2022 -0700

    dzn: Don't delegate binding translation to dxil_spirv_nir_passes()
    
    We will need to hash var bindings if we want to cache DXIL shaders.
    Let's move this pass to dzn_pipeline.c to prepare this transition.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c7b43711f386b732e35d4754e47399be0c3a2d71
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Mon Jun 20 03:43:46 2022 -0700

    dzn: Save a few indentation levels in graphics_pipeline_compile_shaders()
    
    We can compute the yz_flip_mode and force_sample_rate_shading outside
    of the foreach_shader loop.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=84770a90bb3d32a9c2f71cd299edeec1cf702f37
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Mon Jun 20 03:33:32 2022 -0700

    dzn: Use vk_to_mesa_shader_stage()
    
    Use vk_to_mesa_shader_stage() to convert a VkShaderStageFlagBits into
    its gl_shader_stage counterpart.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f4a96675ec41185c90521b1e3e1d573361160b6c
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Mon Jun 20 03:08:52 2022 -0700

    dzn: Fix potential nir_shader leak
    
    We leak the nir_shader object f a failure happens between the NIR
    shader creation and the DXIL compilation. Let's drop the local
    nir_shader pointer and use the one in the graphics_pipeline object
    to avoid that.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=af83f104da6d57c140752b7c1ddb790cf9e668e5
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Fri Jun 17 10:51:59 2022 -0700

    dzn: Let dzn_pipeline_init() initialize the root signature in the stream
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=301fb478feeacc0303832dcd0f050391fbf64287
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Fri Jun 17 19:45:17 2022 +0200

    dzn: Drop unused allocator passed to dzn_graphics_pipeline_create()
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b886619313f46fe10ecf4ba26c9b1d4d603d31f7
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Fri Jun 17 19:43:53 2022 +0200

    dzn: Drop useless while(link_mask != 0)
    
    That's not a `do {} while();`, just a simple `while() {}`, the second
    while statement is a NOP.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=31357f3cf4fb47f87caf21a60caf3167cefe613f
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Fri Jun 17 10:34:19 2022 -0700

    dzn: Pass the maximum stream size to d3d12_pipeline_state_stream_new_desc()
    
    This way we can use d3d12_pipeline_state_stream_new_desc() directly
    without doing
    
       if (type == GRAPHICS)
          d3d12_gfx_pipeline_state_stream_new_desc()
       else
          d3d12_compute_pipeline_state_stream_new_desc()
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e4e531732b5f6417ae89e4ef099ff5c0ee47ad43
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Fri Jun 17 10:28:14 2022 -0700

    dzn: Use d3d12_compute_pipeline_state_stream_new_desc() in the compute path
    
    Fixes: 9feda65a83c ("dzn: Use CreatePipelineState()")
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d3e6ef195a2e55ee2f765153a210c7179b9476ee
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Fri Jun 17 10:26:46 2022 -0700

    dzn: Fix assertion in d3d12_pipeline_state_stream_new_desc()
    
    Fixes: 9feda65a83c ("dzn: Use CreatePipelineState()")
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=26ca9a43441cb69f6934d62fa009317e7e902066
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Fri Jun 17 19:08:36 2022 +0200

    dzn: Add missing D3D12_CACHED_PIPELINE_STATE to MAX_COMPUTE_PIPELINE_STATE_STREAM_SIZE
    
    Fixes: 9feda65a83c ("dzn: Use CreatePipelineState()")
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c66caa1d589e052b5a472fd97ef11503a1e22f67
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Tue Jun 14 02:39:24 2022 -0700

    dzn: Drop dzn_pipeline_cache.c
    
    The core provides a conformant pipeline cache implementation, let's
    use it.
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b59abbe3d57488e7d86d6c71631647f073839957
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Thu Jun 23 04:06:54 2022 -0700

    dzn: Initialize UUIDs
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=be019e69e2c4df7ab2db17a0320b00cf0c6518d8
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Mon Jun 20 13:52:14 2022 +0200

    dzn: Fix indentation
    
    Replace tabs by spaces
    
    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17140>