Mesa (main): freedreno/a6xx: Document border color/swizzle interaction

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 29 03:37:28 UTC 2022


Module: Mesa
Branch: main
Commit: 2a928ae32587ee85894cc2fd7591a4555cf4c224
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2a928ae32587ee85894cc2fd7591a4555cf4c224

Author: Connor Abbott <cwabbott0 at gmail.com>
Date:   Fri Jun 17 00:55:53 2022 +0200

freedreno/a6xx: Document border color/swizzle interaction

Make it clear that the swap happens before border color replacment but
the swizzle happens after.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17177>

---

 src/freedreno/registers/adreno/a6xx.xml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/freedreno/registers/adreno/a6xx.xml b/src/freedreno/registers/adreno/a6xx.xml
index e5f77d3afd9..b5a1a810e36 100644
--- a/src/freedreno/registers/adreno/a6xx.xml
+++ b/src/freedreno/registers/adreno/a6xx.xml
@@ -3853,6 +3853,11 @@ to upconvert to 32b float internally?
 		<bitfield name="CHROMA_MIDPOINT_Y" pos="18" type="boolean"/>
 		<bitfield name="SAMPLES" low="20" high="21" type="a3xx_msaa_samples"/>
 		<bitfield name="FMT" low="22" high="29" type="a6xx_format"/>
+		<!--
+			Why is the swap needed in addition to SWIZ_*? The swap
+			is performed before border color replacement, while the
+			swizzle is applied after after it.
+		-->
 		<bitfield name="SWAP" low="30" high="31" type="a3xx_color_swap"/>
 	</reg32>
 	<reg32 offset="1" name="1">



More information about the mesa-commit mailing list