Mesa (main): util/bitset: Fix off-by-one in __bitset_set_range

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Mar 10 17:51:51 UTC 2022


Module: Mesa
Branch: main
Commit: 410e746198b498efdb9c37a63a0b8aad67469a4c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=410e746198b498efdb9c37a63a0b8aad67469a4c

Author: Connor Abbott <cwabbott0 at gmail.com>
Date:   Mon Jan 10 14:01:34 2022 +0100

util/bitset: Fix off-by-one in __bitset_set_range

Fixes: b3b03e33c9f ("util/bitset: add BITSET_SET_RANGE(..)")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14107>

---

 src/util/bitset.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/bitset.h b/src/util/bitset.h
index 279ad553e79..d8ec1af67ad 100644
--- a/src/util/bitset.h
+++ b/src/util/bitset.h
@@ -208,7 +208,7 @@ __bitset_shl(BITSET_WORD *x, unsigned amount, unsigned n)
 static inline void
 __bitset_set_range(BITSET_WORD *r, unsigned start, unsigned end)
 {
-   const unsigned size = end - start;
+   const unsigned size = end - start + 1;
    const unsigned start_mod = start % BITSET_WORDBITS;
 
    if (start_mod + size <= BITSET_WORDBITS) {



More information about the mesa-commit mailing list