Mesa (main): v3dv: don't emit final noop job if we don't have anything to signal

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: 0273f661e69e61bf9b31af8507090b645a032ddd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0273f661e69e61bf9b31af8507090b645a032ddd

Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Thu Apr 21 11:08:48 2022 +0200

v3dv: don't emit final noop job if we don't have anything to signal

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16235>

---

 src/broadcom/vulkan/v3dv_queue.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/broadcom/vulkan/v3dv_queue.c b/src/broadcom/vulkan/v3dv_queue.c
index 32cd6eb43f7..d14d1b04c21 100644
--- a/src/broadcom/vulkan/v3dv_queue.c
+++ b/src/broadcom/vulkan/v3dv_queue.c
@@ -913,14 +913,16 @@ v3dv_queue_driver_submit(struct vk_queue *vk_queue,
     * This will ensure that the signal semaphores don't get triggered until
     * all work on any queue completes.
     */
-   if (!queue->noop_job) {
-      result = queue_create_noop_job(queue);
+   if (submit->signal_count > 0) {
+      if (!queue->noop_job) {
+         result = queue_create_noop_job(queue);
+         if (result != VK_SUCCESS)
+            return result;
+      }
+      result = queue_handle_job(queue, queue->noop_job, &sync_info, true);
       if (result != VK_SUCCESS)
          return result;
    }
-   result = queue_handle_job(queue, queue->noop_job, &sync_info, true);
-   if (result != VK_SUCCESS)
-      return result;
 
    process_signals(queue, sync_info.signal_count, sync_info.signals);