Mesa (main): anv: re-alloc push constants after secondary command buffers

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue May 10 22:19:40 UTC 2022


Module: Mesa
Branch: main
Commit: 2e46f38902b9409f06f6b3fad6c0666031935794
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2e46f38902b9409f06f6b3fad6c0666031935794

Author: Iván Briano <ivan.briano at intel.com>
Date:   Mon May  9 18:30:20 2022 -0700

anv: re-alloc push constants after secondary command buffers

If the secondary command buffer executed used push constants on a
different set of stages than the primary is using, we may end up not
reallocating them for the primary, getting misrender artifacts at best,
or a nice GPU hang at worst.

Fixes the tests from a CTS from the future:
dEQP-VK.dynamic_rendering.random.*

Cc: mesa-stable

Reviewed-by: Jason Ekstrand <jason.ekstrand at collabora.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16439>

---

 src/intel/vulkan/genX_cmd_buffer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c
index 1bb7ec36bd8..1330355c710 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel/vulkan/genX_cmd_buffer.c
@@ -1995,6 +1995,7 @@ genX(CmdExecuteCommands)(
    primary->state.current_l3_config = NULL;
    primary->state.current_hash_scale = 0;
    primary->state.gfx.dirty |= ANV_CMD_DIRTY_DYNAMIC_ALL;
+   primary->state.gfx.push_constant_stages = 0;
 
    /* Each of the secondary command buffers will use its own state base
     * address.  We need to re-emit state base address for the primary after



More information about the mesa-commit mailing list