Mesa (main): radeonsi/tests: add a --slow option

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri May 20 08:56:24 UTC 2022


Module: Mesa
Branch: main
Commit: c2892b811a2513c56ada7ae68e919235096bf956
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c2892b811a2513c56ada7ae68e919235096bf956

Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date:   Wed May 18 12:55:58 2022 +0200

radeonsi/tests: add a --slow option

Some glcts tests implement tons of tests because they verify
every possible combination of format/swizzle/target/...

They take a long time to execute and aren't possible to run
using multiple processes.

The proper way to fix it would be to split them in vk-gl-cts,
as is already done for some of them (eg es31fTextureGatherTests.cpp).

In the meantime, not running them makes glcts run almost
10 times faster.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16580>

---

 src/gallium/drivers/radeonsi/ci/radeonsi-run-tests.py | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/src/gallium/drivers/radeonsi/ci/radeonsi-run-tests.py b/src/gallium/drivers/radeonsi/ci/radeonsi-run-tests.py
index 086bbd02f5d..6fb56aa0b33 100755
--- a/src/gallium/drivers/radeonsi/ci/radeonsi-run-tests.py
+++ b/src/gallium/drivers/radeonsi/ci/radeonsi-run-tests.py
@@ -97,6 +97,9 @@ parser.add_argument(
 parser.add_argument(
     "--no-deqp", dest="deqp", help="Disable dEQP tests", action="store_false"
 )
+parser.add_argument(
+    "--slow", dest="slow", help="Include slowest glcts tests", action="store_true"
+)
 parser.add_argument(
     "--no-deqp-egl",
     dest="deqp_egl",
@@ -128,6 +131,7 @@ parser.set_defaults(deqp_egl=True)
 parser.set_defaults(deqp_gles2=True)
 parser.set_defaults(deqp_gles3=True)
 parser.set_defaults(deqp_gles31=True)
+parser.set_defaults(slow=False)
 
 parser.add_argument(
     "output_folder",
@@ -250,6 +254,18 @@ logfile = open(os.path.join(output_folder, "{}-run-tests.log".format(gpu_name)),
 
 spin = itertools.cycle("-\\|/")
 
+shutil.copy(skips, output_folder)
+skips = os.path.join(output_folder, "skips.csv")
+if not args.slow:
+    # Exclude these 3 tests slow tests
+    with open(skips, "a") as f:
+        print("KHR-GL46.copy_image.functional", file=f)
+        print("KHR-GL46.texture_swizzle.smoke", file=f)
+        print(
+            "KHR-GL46.tessellation_shader.tessellation_control_to_tessellation_evaluation.gl_MaxPatchVertices_Position_PointSize",
+            file=f,
+        )
+
 
 def gfx_level_to_str(cl):
     supported = ["gfx6", "gfx7", "gfx8", "gfx9", "gfx10", "gfx10_3", "gfx11"]



More information about the mesa-commit mailing list