Mesa (staging/22.1): radv: fix writing buffer markers with non-zero memory offset
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu May 26 16:40:23 UTC 2022
Module: Mesa
Branch: staging/22.1
Commit: 82a8fff872f3a749909b5e22a52c71b2c66ccdc1
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=82a8fff872f3a749909b5e22a52c71b2c66ccdc1
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Tue May 24 23:29:15 2022 +0200
radv: fix writing buffer markers with non-zero memory offset
Found by insepction.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16698>
(cherry picked from commit 1046c2a1c01b27c2bec47f1575236499e7071e53)
---
.pick_status.json | 2 +-
src/amd/vulkan/radv_cmd_buffer.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.pick_status.json b/.pick_status.json
index c3c83f0c6dc..764045d2340 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -31,7 +31,7 @@
"description": "radv: fix writing buffer markers with non-zero memory offset",
"nominated": true,
"nomination_type": 0,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": null
},
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 8432f21700b..f318f0e50f4 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -9214,7 +9214,7 @@ radv_CmdWriteBufferMarker2AMD(VkCommandBuffer commandBuffer, VkPipelineStageFlag
RADV_FROM_HANDLE(radv_cmd_buffer, cmd_buffer, commandBuffer);
RADV_FROM_HANDLE(radv_buffer, buffer, dstBuffer);
struct radeon_cmdbuf *cs = cmd_buffer->cs;
- uint64_t va = radv_buffer_get_va(buffer->bo) + dstOffset;
+ uint64_t va = radv_buffer_get_va(buffer->bo) + buffer->offset + dstOffset;
si_emit_cache_flush(cmd_buffer);
More information about the mesa-commit
mailing list