[Mesa-dev] fixed function vertex program and point sprites

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dave Airlie wrote:
> So I've been trying to make r300g do point sprites for a few days now,
> and I've pulled out quite a lot of hair blaming pieces of hardware
> along with random r300g states.
> 
> I finally noticed I was getting vertex emits for texcoords, which I
> really shouldn't have, and the radeon hw once the VP gets asked to
> emit something to the rasteriser, its overwrites the stuffing values,
> so nothing ever gets stuffed which is quite annoying.
> 
> So I tracked back why the vertex shader was touching texcoords as
> there was no reason for it to in the point sprite case, and this patch
> is the result.
> 
> It seems like the correct thing to do but comment as to what it might
> violate are welcome.
> 
> Thanks,
> Dave.

This should be the right approach.  The only possible gotcha is the
per-unit enable / disable, but it looks like you got that covered.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkvDXPQACgkQX1gOwKyEAw8T0ACeKE+gT1KjlBtNSotmZQR8tk/L
LIgAnRbapQLeGxVirU2UV2zHei9SSnKC
=2VFG
-----END PGP SIGNATURE-----