[Mesa-dev] [PATCH] DRI2: report swap events correctly in direct rendered case

Jesse Barnes jesse.barnes at intel.com
Mon Apr 12 09:56:44 PDT 2010


In the direct rendered case, we need to convert DRI2 swap complete
events to GLX events for the client to consume.  This path had what
looks like a stray "& 0x75" from some earlier debugging that prevented
clients from seeing the right event code.

However the GLX event code has bitten us a few times in the past, so
I'd like to get review on this (and the DRI2WireToEvent function in
general) before pushing.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

diff --git a/src/glx/dri2.c b/src/glx/dri2.c
index 9ca9b3e..7d46878 100644
--- a/src/glx/dri2.c
+++ b/src/glx/dri2.c
@@ -101,8 +101,7 @@ DRI2WireToEvent(Display *dpy, XEvent *event, xEvent *wire)
       GLXBufferSwapComplete *aevent = (GLXBufferSwapComplete *)event;
       xDRI2BufferSwapComplete *awire = (xDRI2BufferSwapComplete *)wire;
       aevent->serial = _XSetLastRequestRead(dpy, (xGenericReply *) wire);
-      aevent->type =
-	  (glx_info->codes->first_event + GLX_BufferSwapComplete) & 0x75;
+      aevent->type = glx_info->codes->first_event + GLX_BufferSwapComplete;
       aevent->send_event = (awire->type & 0x80) != 0;
       aevent->display = dpy;
       aevent->drawable = awire->drawable;



More information about the mesa-dev mailing list